Conversation
titaniumbones
left a comment
There was a problem hiding this comment.
Hi Michael, see my comments , which are attached to line numbers in your PR.
json-files/Michael
Outdated
| "periods": ["ancient", "medieval", "early modern", "modern", "contemporary"], | ||
| "regions": ["Europe", "North America"], | ||
| "styles": ["political", "diplomatic", "cultural", "social", "art", "intellectual", "economic"], | ||
| "picture": "../images/your-image.jpg", |
There was a problem hiding this comment.
change this to a URL:
- either upload an image of yourself to the "dist/images" folder and change this value to reflect the precise name of your image
- or, alternatively, point to the full URL of an existing image on the internet.
There was a problem hiding this comment.
I think I have completed this.
json-files/Michael
Outdated
| "regions": ["Europe", "North America"], | ||
| "styles": ["political", "diplomatic", "cultural", "social", "art", "intellectual", "economic"], | ||
| "picture": "../images/your-image.jpg", | ||
| "blurb": "../markdown-files/your-markdown-file.md" |
There was a problem hiding this comment.
change this to reflect the actual name of hte markdown file you wrote -- which right now is ../markdown-files/"Michael . You should however rename this file to Michael.md if you are able to do so -- and if you can, then adjust this value accordingly.
markdown-files/Michael
Outdated
| @@ -0,0 +1,5 @@ | |||
| #Research Interests | |||
There was a problem hiding this comment.
add space between # and Research
There was a problem hiding this comment.
also, as I mentioned, this file should be renamed "Michael.md"
There was a problem hiding this comment.
I think I have completed this.
I'm really just asking you to do things you've already done? You simply edit the files you have already edited. But we cna discuss in/after class. |
|
Hi Michael,
|
|
Excellent. I will resolve these outstanding issues shortly. Thanks again, Matt. |
Correcting mystery space.
Closing spaces.
Correcting image file extension.
No description provided.