Alert-system: Email setup #2638
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ix notification tests
2 tasks
sudip-khanal
changed the title
susilnem
requested changes
Jan 27, 2026
|
|
||
|
|
||
| @shared_task() | ||
| def process_email_alert(load_item_id: int) -> None: |
Member
There was a problem hiding this comment.
We might need a separate Queue for the alert notification..
alert_system/utils.py
Outdated
|
|
||
| def get_alert_subscriptions(load_item: LoadItem): | ||
|
|
||
| regions = Country.objects.filter(iso3__in=load_item.country_codes).values_list("region_id", flat=True) |
Member
There was a problem hiding this comment.
Suggested change
| regions = Country.objects.filter(iso3__in=load_item.country_codes).values_list("region_id", flat=True) | |
| region_ids = Country.objects.filter(iso3__in=load_item.country_codes).values_list("region_id", flat=True) |
alert_system/tasks.py
Outdated
| logger.warning(f"LoadItem with ID [{load_item_id}] not found") | ||
| return | ||
|
|
||
| subscriptions = get_alert_subscriptions(load_item) |
Member
There was a problem hiding this comment.
Suggested change
| subscriptions = get_alert_subscriptions(load_item) | |
| subscriptions = list(get_alert_subscriptions(load_item)) |
| created_at = models.DateTimeField(auto_now_add=True, verbose_name=_("Created At")) | ||
| updated_at = models.DateTimeField(auto_now=True, verbose_name=_("Updated At")) | ||
| # Typing | ||
| id: int |
Member
There was a problem hiding this comment.
Suggested change
| id: int | |
| user_id: int | |
| ) | ||
|
|
||
| created_at = models.DateTimeField(auto_now_add=True) | ||
|
|
Member
There was a problem hiding this comment.
Suggested change
| # TYPING | |
| user_id: int |
alert_system/tasks.py
Outdated
Comment on lines
222
to
227
| threads_qs = AlertEmailThread.objects.filter( | ||
| correlation_id=load_item.correlation_id, | ||
| user_id__in=user_ids, | ||
| ).select_related("user") | ||
|
|
||
| existing_threads = {thread.user.id: thread for thread in threads_qs} |
Member
There was a problem hiding this comment.
Suggested change
| threads_qs = AlertEmailThread.objects.filter( | |
| correlation_id=load_item.correlation_id, | |
| user_id__in=user_ids, | |
| ).select_related("user") | |
| existing_threads = {thread.user.id: thread for thread in threads_qs} | |
| existing_threads = { | |
| thread.user_id: thread | |
| for thread in AlertEmailThread.objects.filter( | |
| correlation_id=load_item.correlation_id, | |
| user_id__in=user_ids, | |
| ) | |
| } | |
alert_system/tasks.py
Outdated
|
|
||
| today = timezone.now().date() | ||
| subscriptions_list = list(subscriptions) | ||
| user_ids = [sub.user.id for sub in subscriptions_list] |
Member
There was a problem hiding this comment.
Suggested change
| user_ids = [sub.user.id for sub in subscriptions_list] | |
| user_ids = [sub.user_id for sub in subscriptions_list] |
| verbose_name=_("Email Thread"), | ||
| ) | ||
|
|
||
| id: int |
Member
There was a problem hiding this comment.
Suggested change
| id: int | |
| id: int | |
| user_id: int |
deploy/helm/ifrcgo-helm/values.yaml
Outdated
Comment on lines
280
to
287
| # - command: 'poll_gdacs_cyclone' | ||
| # schedule: '0 0 * * 0' | ||
| - command: 'poll_gdacs_flood' | ||
| schedule: '0 0 * * 0' | ||
| - command: 'poll_usgs_earthquake' | ||
| schedule: '0 0 * * 0' | ||
| # - command: 'notify_validators' | ||
| # schedule: '0 0 * * *' | ||
| schedule: '15 9 * * *' | ||
| # - command: 'poll_usgs_earthquake' | ||
| # schedule: '0 0 * * 0' | ||
| - command: 'alert_notification' | ||
| schedule: '0 */2 * * *' |
Member
There was a problem hiding this comment.
Are we commenting this for local use? If yes, please make it how it should be.
Contributor
Author
There was a problem hiding this comment.
Commenting out because this will flood database (we are just running the poll_gdacs_flood for now)
main/sentry.py
Outdated
Comment on lines
132
to
136
| # POLL_USGS_EARTHQUAKE = "poll_usgs_earthquake", "0 0 * * 0" | ||
| POLL_GDACS_FLOOD = "poll_gdacs_flood", "15 9 * * *" | ||
| # POLL_GDACS_CYCLONE = "poll_gdacs_cyclone", "0 0 * * 0" | ||
| OAUTH_CLEARTOKENS = "oauth_cleartokens", "0 1 * * *" | ||
| ALERT_NOTIFICATION = "alert_notification", "0 */2 * * *" |
- Add new ALERT celery queue - Route process_email_alert task to ALERT queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Checklist
Things that should succeed before merging.
Release
If there is a version update, make sure to tag the repository with the latest version.