cog-launcher: fix system dbus appid connection #762
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aperezdc
approved these changes
Jun 23, 2025
Member
aperezdc
left a comment
aperezdc
left a comment
There was a problem hiding this comment.
Patch looks good to me, thanks!
Member
|
@woutervanh Could you rebase this on top of the current state of the |
Contributor
Author
|
done |
Member
|
@woutervanh It looks like I'll have to poke at the CI a bit more to have it running, but let's just merge this for the time being. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On system dbus connection, the appid passed to the launcher was not taken into consideration yet, so taking the default id. This made it impossible to address multiple browser instances on the system bus. I moved the call to a place where we can take the appid. The end user is still responsible for creating the correct policy file!
Fixes:
#474