Improve interoperability between `SyclDevice` and DLPack devices by ndgrigorian · Pull Request #1953 · IntelPython/dpctl

ndgrigorian · 2025-01-04T03:42:13Z

This PR proposes improving dpctl's interoperability with DLPack by

Adding a new method get_device_id to dpctl.SyclDevice which returns the ordinal ID of a root device
Adding new functions dpctl.tensor.dldevice_to_sycldevice and its converse dpctl.tensor.sycldevice_to_dldevice which function as conversions between dpctl.SyclDevices and the DLPack device tuples returned by arr.__dlpack_device__() for some array arr from an arbitrary array library

Closes #1929

Have you provided a meaningful PR description?
Have you added a test, reproducer or referred to an issue with a reproducer?
Have you tested your changes locally for CPU and GPU devices?
Have you made sure that new changes do not introduce compiler warnings?
Have you checked performance impact of proposed changes?
Have you added documentation for your changes, if necessary?
Have you added your changes to the changelog?
If this PR is a work in progress, are you opening the PR as a draft?

dpctl/tensor/_dldevice_conversions.py

github-actions · 2025-01-04T04:18:28Z

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

github-actions · 2025-01-04T04:23:48Z

Array API standard conformance tests for dpctl=0.19.0dev0=py310h93fe807_368 ran successfully.
Passed: 894
Failed: 2
Skipped: 118

github-actions · 2025-01-07T19:33:46Z

Array API standard conformance tests for dpctl=0.19.0dev0=py310h93fe807_411 ran successfully.
Passed: 893
Failed: 3
Skipped: 118

coveralls · 2025-01-07T19:39:45Z

coverage: 87.721% (+0.04%) from 87.683%
when pulling b1a5ecd on dlpack-enum-sycl-device-interop
into 25a53f5 on master.

github-actions · 2025-01-07T22:49:46Z

Array API standard conformance tests for dpctl=0.19.0dev0=py310h93fe807_413 ran successfully.
Passed: 894
Failed: 2
Skipped: 118

github-actions · 2025-01-09T20:16:27Z

Array API standard conformance tests for dpctl=0.19.0dev0=py310h93fe807_415 ran successfully.
Passed: 893
Failed: 3
Skipped: 118

dpctl/_sycl_device.pyx

dpctl/tensor/_dldevice_conversions.py

ndgrigorian · 2025-01-10T18:46:07Z

@icfaust
This PR implements new DLPack functions in line with your request

github-actions · 2025-01-13T10:14:55Z

Array API standard conformance tests for dpctl=0.19.0dev0=py310h93fe807_436 ran successfully.
Passed: 894
Failed: 2
Skipped: 118

github-actions · 2025-01-13T17:54:03Z

Array API standard conformance tests for dpctl=0.19.0dev0=py310h93fe807_440 ran successfully.
Passed: 894
Failed: 2
Skipped: 118

dpctl/_sycl_device.pyx

github-actions · 2025-01-13T20:44:19Z

Array API standard conformance tests for dpctl=0.19.0dev0=py310h93fe807_441 ran successfully.
Passed: 894
Failed: 2
Skipped: 118

github-actions · 2025-01-14T01:37:56Z

Array API standard conformance tests for dpctl=0.19.0dev0=py310h93fe807_440 ran successfully.
Passed: 894
Failed: 2
Skipped: 118

dpctl/_sycl_device.pyx

oleksandr-pavlyk · 2025-01-14T12:06:10Z

The docstring for the newly added method did not render well:

The example included in the docstring is missing. I suspect this is due to missing empty lines around :Example:.

github-actions · 2025-01-14T18:04:08Z

Array API standard conformance tests for dpctl=0.19.0dev0=py310h93fe807_450 ran successfully.
Passed: 894
Failed: 2
Skipped: 118

ndgrigorian · 2025-01-14T19:22:55Z

@oleksandr-pavlyk
The documentation rendering issue has been fixed.

github-actions · 2025-01-14T19:25:11Z

Array API standard conformance tests for dpctl=0.19.0dev0=py310h93fe807_452 ran successfully.
Passed: 894
Failed: 2
Skipped: 118

github-actions · 2025-01-14T20:14:15Z

Array API standard conformance tests for dpctl=0.19.0dev0=py310h93fe807_452 ran successfully.
Passed: 894
Failed: 2
Skipped: 118

dpctl/_sycl_device.pyx

Full dpctl namespace is unnecessary, as only SyclDevice is used

github-actions · 2025-01-15T19:37:47Z

Array API standard conformance tests for dpctl=0.19.0dev0=py310h93fe807_460 ran successfully.
Passed: 894
Failed: 2
Skipped: 118

github-actions · 2025-01-15T19:47:31Z

Array API standard conformance tests for dpctl=0.19.0dev0=py310h93fe807_462 ran successfully.
Passed: 894
Failed: 2
Skipped: 118

github-actions · 2025-01-15T20:17:33Z

Array API standard conformance tests for dpctl=0.19.0dev0=py310h93fe807_462 ran successfully.
Passed: 894
Failed: 2
Skipped: 118

oleksandr-pavlyk

Thank you for working on this, @ndgrigorian

Sorry it took a few iterations, but it all looks good now, and we caught few legacy issues too.

ndgrigorian · 2025-01-15T23:33:17Z

Thank you for working on this, @ndgrigorian

Sorry it took a few iterations, but it all looks good now, and we caught few legacy issues too.

Yes, and it cleans up the DLPack code quite nicely.

oleksandr-pavlyk reviewed Jan 4, 2025

View reviewed changes

dpctl/tensor/_dldevice_conversions.py Outdated Show resolved Hide resolved

dpctl/tensor/_dldevice_conversions.py Outdated Show resolved Hide resolved

ndgrigorian force-pushed the dlpack-enum-sycl-device-interop branch 2 times, most recently from ac69747 to eb7f4fe Compare January 7, 2025 18:49

ndgrigorian force-pushed the dlpack-enum-sycl-device-interop branch from eb7f4fe to c529b29 Compare January 7, 2025 22:05

ndgrigorian marked this pull request as ready for review January 7, 2025 22:06

oleksandr-pavlyk reviewed Jan 10, 2025

View reviewed changes

dpctl/_sycl_device.pyx Outdated Show resolved Hide resolved

oleksandr-pavlyk reviewed Jan 10, 2025

View reviewed changes

dpctl/_sycl_device.pyx Show resolved Hide resolved

oleksandr-pavlyk reviewed Jan 10, 2025

View reviewed changes

dpctl/tensor/_dldevice_conversions.py Outdated Show resolved Hide resolved

ndgrigorian force-pushed the dlpack-enum-sycl-device-interop branch from f010c23 to 5d4c8e8 Compare January 13, 2025 09:29

ndgrigorian force-pushed the dlpack-enum-sycl-device-interop branch from 5d4c8e8 to ec6c1d9 Compare January 13, 2025 17:05

oleksandr-pavlyk reviewed Jan 13, 2025

View reviewed changes

dpctl/_sycl_device.pyx Outdated Show resolved Hide resolved

ndgrigorian force-pushed the dlpack-enum-sycl-device-interop branch from 9559620 to b1e8df1 Compare January 14, 2025 00:54

oleksandr-pavlyk reviewed Jan 14, 2025

View reviewed changes

dpctl/_sycl_device.pyx Outdated Show resolved Hide resolved

oleksandr-pavlyk reviewed Jan 14, 2025

View reviewed changes

dpctl/_sycl_device.pyx Outdated Show resolved Hide resolved

ndgrigorian force-pushed the dlpack-enum-sycl-device-interop branch from 64687a2 to 7a9c6a8 Compare January 14, 2025 19:31

oleksandr-pavlyk reviewed Jan 15, 2025

View reviewed changes

dpctl/_sycl_device.pyx Outdated Show resolved Hide resolved

ndgrigorian force-pushed the dlpack-enum-sycl-device-interop branch from 50a5523 to afce3b3 Compare January 15, 2025 19:03

ndgrigorian added 13 commits January 15, 2025 11:04

Add get_device_id method to SyclDevice

6781a82

Adds conversion functions for dldevice and dpctl.SyclDevice

ea6e061

import SyclDevice directly in _dldevice_conversions

d972d07

Full dpctl namespace is unnecessary, as only SyclDevice is used

Add tests for dldevice and sycldevice interchange functions

2583383

Add tests for dpctl.SyclDevice.get_device_id method

7d35624

use sycl_device instead of sycldevice in dldevice conversion functions

f15778e

Change errors throughout _sycl_device.pyx

14c7dc5

Add docstring for dpctl.SyclDevice.get_device_id

55944bc

Fix incorrect SyclDevice docstring

d3058ac

Fix missing line breaks in get_device_id method

d5cbe3f

Fix get_device_id example spacing

66d8025

Adds get_unpartitioned_parent_device method to SyclDevice

cda903b

Use get_device_id to find DLpack device ID

b1a5ecd

ndgrigorian force-pushed the dlpack-enum-sycl-device-interop branch from afce3b3 to b1a5ecd Compare January 15, 2025 19:34

ndgrigorian requested a review from oleksandr-pavlyk January 15, 2025 19:34

oleksandr-pavlyk approved these changes Jan 15, 2025

View reviewed changes

ndgrigorian merged commit a86da4b into master Jan 15, 2025
62 checks passed

ndgrigorian deleted the dlpack-enum-sycl-device-interop branch January 15, 2025 23:32

icfaust mentioned this pull request Mar 23, 2025

[testing] match dpctl attribute get_device_id attribute in backend SyclDevice object uxlfoundation/scikit-learn-intelex#2292

Merged

13 tasks

Conversation

ndgrigorian commented Jan 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Jan 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jan 4, 2025

Uh oh!

github-actions bot commented Jan 7, 2025

Uh oh!

coveralls commented Jan 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jan 7, 2025

Uh oh!

github-actions bot commented Jan 9, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ndgrigorian commented Jan 10, 2025

Uh oh!

github-actions bot commented Jan 13, 2025

Uh oh!

github-actions bot commented Jan 13, 2025

Uh oh!

Uh oh!

github-actions bot commented Jan 13, 2025

Uh oh!

github-actions bot commented Jan 14, 2025

Uh oh!

Uh oh!

Uh oh!

oleksandr-pavlyk commented Jan 14, 2025

Uh oh!

github-actions bot commented Jan 14, 2025

Uh oh!

ndgrigorian commented Jan 14, 2025

Uh oh!

github-actions bot commented Jan 14, 2025

Uh oh!

github-actions bot commented Jan 14, 2025

Uh oh!

Uh oh!

github-actions bot commented Jan 15, 2025

Uh oh!

github-actions bot commented Jan 15, 2025

Uh oh!

github-actions bot commented Jan 15, 2025

Uh oh!

oleksandr-pavlyk left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

ndgrigorian commented Jan 15, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

ndgrigorian commented Jan 4, 2025 •

edited

Loading

github-actions bot commented Jan 4, 2025 •

edited

Loading

coveralls commented Jan 7, 2025 •

edited

Loading