Implement __usm_ndarray__ protocol#2261
Merged
antonwolfy merged 3 commits intomasterfrom Jan 20, 2025
Merged
Conversation
Collaborator
8 tasks
antonwolfy
requested review from
AlexanderKalistratov,
vlad-perevezentsev and
vtavana
as code owners
Contributor
|
Array API standard conformance tests for dpnp=0.17.0dev4=py312he4f9c94_9 ran successfully. |
vlad-perevezentsev
approved these changes
Jan 20, 2025
Contributor
vlad-perevezentsev
left a comment
vlad-perevezentsev
left a comment
There was a problem hiding this comment.
Looks good!
Thank you @antonwolfy
antonwolfy
deleted the
tensor-asarray-support-for-usm-ndarray-protocol
branch
github-actions bot
added a commit
that referenced
this pull request
Jan 20, 2025
The PR is intended to adopt to dpctl changes implemented in [dpctl#1959](IntelPython/dpctl#1959). It implements support of `__usm_ndarray__` protocol for `dpnp.ndarray` and returns a property with `dpctl.tensor.usm_ndarray` instance corresponding to the content of the array object. This property is intended to speed-up conversion from `dpnp.ndarray` to `dpt.usm_ndarray` in `x=dpt.asarray(dpnp_array_obj)`. The input object that implements `__usm_ndarray__` is recognized as owner of USM allocation that is managed by a smart pointer, and asynchronous deallocation of `x` need not involve GIL. 9ad1bb5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR is intended to adopt to dpctl changes implemented in dpctl#1959.
It implements support of
__usm_ndarray__protocol fordpnp.ndarrayand returns a property withdpctl.tensor.usm_ndarrayinstance corresponding to the content of the array object.This property is intended to speed-up conversion from
dpnp.ndarraytodpt.usm_ndarrayinx=dpt.asarray(dpnp_array_obj).The input object that implements
__usm_ndarray__is recognized as owner of USM allocation that is managed by a smart pointer, and asynchronous deallocation ofxneed not involve GIL.