fix: move debug from devDependencies to dependencies #197
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes ItzDerock#196 The debug module was incorrectly placed in devDependencies, causing 'Cannot find module debug' errors when the package is installed from npm. This fix moves debug to dependencies where it belongs since it's imported in src/downloader/images.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #196
Problem
The
debugmodule was incorrectly placed indevDependencies, causing "Cannot find module 'debug'" errors when the package is installed from pnpm. This broke version 3.3.0 for all users.Solution
Moved
debugfromdevDependenciestodependenciessince it's imported and used in src/downloader/images.ts.Testing