Update JIRA ID pattern to include digits and underscores #3336
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| private static final boolean REDISCOVER_API = Boolean.getBoolean("tasks.jira.rediscover.api"); | ||
|
|
||
| public static final Pattern JIRA_ID_PATTERN = Pattern.compile("\\p{javaUpperCase}+-\\d+"); | ||
| public static final Pattern JIRA_ID_PATTERN = Pattern.compile("[\\p{javaUpperCase}\\p{Digit}_]+-\\d+"); |
There was a problem hiding this comment.
Bug: Regex allows JIRA IDs starting with digits or underscores
The updated JIRA_ID_PATTERN regex now matches strings like 123-456 or ___-123 because it allows digits and underscores as the first character. JIRA project keys must start with a letter, so the pattern should enforce that the first character is an uppercase letter, with digits and underscores allowed only in subsequent positions. This could cause unnecessary API calls when user input like 123-456 incorrectly matches the pattern.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves (probably) IJPL-221819 Cannot connect to Jira Cloud
Note
Expands the
JIRA_ID_PATTERNto accept digits and underscores in project keys.JIRA_ID_PATTERNinJiraRepositoryfrom\p{javaUpperCase}+-\d+to[\p{javaUpperCase}\p{Digit}_]+-\d+to recognize issue keys with digits/underscores in the project part.Written by Cursor Bugbot for commit 646349a. This will update automatically on new commits. Configure here.