Skip to content

New method for derivative of constant ImmutableDensePolynomial #615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jverzani merged 2 commits into from
Sep 27, 2025
Merged

New method for derivative of constant ImmutableDensePolynomial #615

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e63df3d
Include a method for derivative of constant `ImmutableDensePolynomial…
iojea Sep 27, 2025
7ee9cdc
Improved derivative for constant `ImmutablePolynomial`. `derivative(p…
iojea Sep 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/polynomials/standard-basis/immutable-polynomial.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,8 +142,11 @@ end

# special cases are much more performant
derivative(p::ImmutableDensePolynomial{B,T,X,0}) where {B<:StandardBasis,T,X} = p
derivative(p::ImmutableDensePolynomial{B,T,X,1}) where {B<:StandardBasis,T,X} = zero(p)

function derivative(p::ImmutableDensePolynomial{B,T,X,N}) where {B<:StandardBasis,T,X,N}
N == 0 && return p
N == 1 && return zero(p)
Copy link
Member

@jverzani jverzani Sep 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like rather than add a case, we can remove the N==0 case which is captured in the special case above.

Copy link

@KlausC KlausC Sep 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think, both cases (N == 0 and N == 1) are covered by the more specific functions in lines 145 and 146, so could be both removed.

Copy link
Member

@jverzani jverzani Sep 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed

hasnan(p) && return ImmutableDensePolynomial{B,T,X,1}(zero(T)/zero(T)) # NaN{T}
cs = ntuple(i -> i*p.coeffs[i+1], Val(N-1))
R = eltype(cs)
Expand Down
Loading