remove -mfpu=neon for aarch64#50
Open
mchalain wants to merge 2 commits intoKhronosGroup:openvx_1.3from
Open
Conversation
The neon fpu is mandatory for aarch64, and GCC doesn't recognize this option.
|
|
There was a problem hiding this comment.
Pull Request Overview
This PR removes the GCC unsupported "-mfpu=neon" flag for aarch64 builds by updating the CMake logic.
- Removed the condition that set ARCH_BIT to "-mfpu=neon".
- Now, when no experimental features are enabled, ARCH_BIT is set to "-m64", relying on aarch64’s mandatory neon FPU.
Comments suppressed due to low confidence (1)
cmake_utils/CMake_linux_tools.cmake:31
- When any of EXPERIMENTAL_USE_VENUM, OPENVX_USE_TILING, or EXPERIMENTAL_USE_OPENCL are enabled, ARCH_BIT is left unset. Please confirm that this behavior is intentional and that a default value is not required for these cases.
if (NOT EXPERIMENTAL_USE_VENUM AND NOT OPENVX_USE_TILING AND NOT EXPERIMENTAL_USE_OPENCL)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The neon fpu is mandatory for aarch64, and GCC doesn't recognize this option.
Tested with Raspberry Pi 4 64bits