Skip to content

gpuav: Add full native Spec Constant support#11752

Merged
spencer-lunarg merged 1 commit intoKhronosGroup:mainfrom
spencer-lunarg:spencer-lunarg-finally-got-nerd-snipped-to-just-roll-our-own-constant-folding
Feb 26, 2026
Merged

gpuav: Add full native Spec Constant support#11752
spencer-lunarg merged 1 commit intoKhronosGroup:mainfrom
spencer-lunarg:spencer-lunarg-finally-got-nerd-snipped-to-just-roll-our-own-constant-folding

Conversation

@spencer-lunarg
Copy link
Contributor

closes #11747 (in prep for replacing in #11717)

Adds (for GPU-AV only currently) our own way to do spirv-opt's constant folding

The main 2 reasons for all this works

  1. Will be faster than transferring between spirv-opt and back (pipeline compilation time is already an issue for GPU-AV)
  2. We can do constant folding and preserve the "index" into the SPIR-V such that we provide a correct error message when printing the error source

@spencer-lunarg spencer-lunarg requested a review from a team as a code owner February 25, 2026 22:18
@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build queued with queue ID 662172.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build # 22604 running.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build # 22604 failed.

@spencer-lunarg spencer-lunarg force-pushed the spencer-lunarg-finally-got-nerd-snipped-to-just-roll-our-own-constant-folding branch from 5bfb0b6 to 5cef79c Compare February 26, 2026 04:37
@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build queued with queue ID 662380.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build # 22605 running.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build # 22605 failed.

@spencer-lunarg spencer-lunarg force-pushed the spencer-lunarg-finally-got-nerd-snipped-to-just-roll-our-own-constant-folding branch from 5cef79c to f76b32e Compare February 26, 2026 13:49
@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build queued with queue ID 662710.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build # 22606 running.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build # 22606 failed.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build queued with queue ID 662785.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build # 22608 running.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build # 22608 passed.

@artem-lunarg
Copy link
Contributor

That's once piece of compiler technology here.

@spencer-lunarg
Copy link
Contributor Author

That's once piece of compiler technology here.

This why I was late to the meeting yesterday, I had to go full Compiler Engineer on this

@spencer-lunarg spencer-lunarg force-pushed the spencer-lunarg-finally-got-nerd-snipped-to-just-roll-our-own-constant-folding branch from f76b32e to a298062 Compare February 26, 2026 20:00
@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build queued with queue ID 663038.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build # 22615 running.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build # 22615 failed.

@spencer-lunarg
Copy link
Contributor Author

CI Vulkan-ValidationLayers build # 22615 failed.

unrelated mac error

@spencer-lunarg spencer-lunarg merged commit 1726157 into KhronosGroup:main Feb 26, 2026
21 of 22 checks passed
@spencer-lunarg spencer-lunarg deleted the spencer-lunarg-finally-got-nerd-snipped-to-just-roll-our-own-constant-folding branch February 26, 2026 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add our internal Constant Folding

4 participants