Skip to content

Conversation

@finetjul
Copy link
Member

@finetjul finetjul commented Nov 9, 2025

Context

VTK.js is lacking an example to programmatically place a widget.

Results

Improve the seed widget API and enhance its example.

Changes

  • Documentation and TypeScript definitions were updated to match those changes

PR and Code Checklist

  • semantic-release commit messages
  • Run npm run reformat to have correctly formatted code

Testing

  • This change adds or fixes unit tests
  • Tested environment:
    • vtk.js: master
    • OS: Windows 11
    • Browser: Chrome

Demonstrate how to programmatically place a seed widget and to make the widget interactive.
@finetjul finetjul force-pushed the seedwidget-programatic-placement branch from 75f9c73 to 4efbc28 Compare January 4, 2026 22:36
@finetjul finetjul enabled auto-merge January 4, 2026 22:37
@finetjul finetjul added this pull request to the merge queue Jan 4, 2026
Merged via the queue into Kitware:master with commit 4ea572c Jan 4, 2026
2 checks passed
@daker
Copy link
Collaborator

daker commented Jan 5, 2026

@finetjul not sure if it's related but the last release job failed:

2026-01-04T22:44:25.0308531Z Firefox 146.0 (Linux x86_64) INFO: 'Test Suite: Test HardwareSelector'
2026-01-04T22:44:25.0309492Z Firefox 146.0 (Linux x86_64) INFO: '	[PASS] vtkHardwareSelector TestHardwareSelector'
2026-01-04T22:44:25.0310749Z Firefox 146.0 (Linux x86_64) INFO: '	[FAIL] Hardware selector takes less than ten normal renders (1654, 134, 1586)'

@finetjul
Copy link
Member Author

finetjul commented Jan 6, 2026

@finetjul not sure if it's related but the last release job failed

This is unrelated, the Hardware Selector test does not use the SeedWidget therefore this commit can't impact the test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants