[Core] Fixed writing JSON output for nodal vector variables #14076
Conversation
The JSON output process was lacking a conversion from a Kratos vector to a Python list. Also added two regression tests.
rfaasse
left a comment
rfaasse
left a comment
There was a problem hiding this comment.
Thank you for fixing the Vector output of the json output process! I have two minor suggestions for clarifications and I think we still need to add the test to the appropriate suite to make sure it runs in the pipeline 👍
This eases to understand the test assertions.
rfaasse
left a comment
rfaasse
left a comment
There was a problem hiding this comment.
To me this is ready to go, but I'll leave the approval to the technical committee!
indigocoral
left a comment
indigocoral
left a comment
There was a problem hiding this comment.
Hi Anne,
Thank you for this vector output of the json output fix.
I've only got a question about the test output and a tiny remark. Hope it's clear!
indigocoral
left a comment
indigocoral
left a comment
There was a problem hiding this comment.
Thank you for the explanations. No further comments from my side.
github-project-automation
bot
moved this from 👀 In Review
to ✅ Done
in Kratos Product Backlog
Thanks, Marjan. I'll wait with merging to |
…json-output-process
|
Just a friendly reminder to @KratosMultiphysics/technical-committee and @loumalouomega that we're waiting for you to review this PR. Thank you. |
I am out of office until 7th January, I think I will not be able to review until then. |
Thanks for letting us know. No worries, we can wait until you're back. |
📝 Description
The JSON output process was lacking a conversion from a Kratos vector to a Python list in case of vector variables.
Also added two regression tests.