Make SkipConnection have the same args as Parallel

[Qfl3x]

Just a small pet-peeve, feel free to close without pulling. Parallel and SkipConnection don't have the same syntax despite being very similar in their action;

Parallel(connection, layers...)

SkipConnection(layers, connection)

Since Parallel has splatted layers argument, I've changed SkipConnection.

[gemini-code-assist]

Summary of Changes

Hello @Qfl3x, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a minor API inconsistency by reordering the arguments of the SkipConnection constructor. The change aligns its signature with that of Parallel, making the API more predictable and easier to use for developers. This is a quality-of-life improvement for the library.

Highlights

• API Consistency: The argument order for SkipConnection has been reversed to (connection, layers...) to match the Parallel constructor, improving API consistency.
• Documentation Update: The docstring for SkipConnection has been updated to reflect the new argument order and provide a consistent example.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request updates the SkipConnection constructor to align its argument order with Parallel, improving API consistency. The changes in src/layers/containers.jl correctly swap the connection and layers arguments in the positional constructor and update the docstring accordingly. My main concern, which is critical, is that this is a breaking change and the tests have not been updated, which will cause the build to fail.

[Qfl3x]

I've updated tests and docs. However, I don't understand the "Bilinear - SkipConnection recombinator" tests;

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 68.34%. Comparing base (a0a6719) to head (38350f9).
⚠️ Report is 1 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (a0a6719) and HEAD (38350f9). Click for more details.

HEAD has 45 uploads less than BASE

Flag	BASE (a0a6719)	HEAD (38350f9)
	53	8

Additional details and impacted files

@@             Coverage Diff             @@
##             main    #1481       +/-   ##
===========================================
- Coverage   84.23%   68.34%   -15.90%     
===========================================
  Files         166      153       -13     
  Lines        6724     6662       -62     
===========================================
- Hits         5664     4553     -1111     
- Misses       1060     2109     +1049     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[avik-pal]

While I agree that at some point we need to make this change, we can't do it in v1.x.x due to semantic versioning requirements. I will hold off merging this till we are ready for a breaking major change.