Epssm(z) generalization of the parameter epssm in the MPAS dycore#1381
Open
skamaroc wants to merge 4 commits intoMPAS-Dev:developfrom
Open
Epssm(z) generalization of the parameter epssm in the MPAS dycore#1381skamaroc wants to merge 4 commits intoMPAS-Dev:developfrom
skamaroc wants to merge 4 commits intoMPAS-Dev:developfrom
Conversation
…nt for the vertically (column-wise) semi-implicit acoustic/gravity-wave integration. Presently the coefficent is a single constant. We now allow this coefficient to vary with model and interface levels as a function of height zeta between two values with a transition layer between the two. This commit, to the Registry only, adds namelist control variables for specifying the lower and upper values of epssm and the lower and upper heights of the transition region for these values. The commit also includes Registry-defined arrays storing the values (1 +- epssm(z))/2 at the levels and interfaces needed in the solution procedure.
…_core.F to initialize the Registry-defined arrays storing the values (1 +- epssm(z))/2 at the levels and interfaces needed in the solution procedure. The initialization occurs at model integration start up. The vertically varying epssm is NOT active at this point; the simulation still uses the constant value from config_epssm.
the coefficients for the vertically-implicit acoustic solution to use the variable epssm formulation, and modified the acoustic step solver to use the variable epssm coefficients. This commit changes the solution at roundoff level even if a constant epssm is configured because we have changed the order of the computations in some places and we have incorporated the acoustic timestep delta tau in a different manner than in the previous formulation.
to the intended general configuration for real-data cases.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Variable epssm(zeta) introduction: epssm is an offcentering coefficient for
the vertically (column-wise) semi-implicit acoustic/gravity-wave integration.
Presently the coefficient is a single constant. We now allow this coefficient
to vary with model and interface levels as a function of height zeta between
two values with a transition layer between the two.
4 commits on top of V8.3.1