Open
Conversation
Conflicts: ocean/wave_mesh_tools/CMakeLists.txt
Collaborator
|
Impressive work, @erinethomas and @sbrus89! For now, my suggestion would be to add a few tests to: |
Author
|
good suggestion - ill try to get those done before the end of the week |
Collaborator
|
I was able to build the conda package on Chrysalis so this looks great to me from a technical perspective. Let me know if you want me to test actually running any of these tools. |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds all the tools required for creating WAVEWATCHIII meshes