Conversation
|
@alicebarthel The changes visually look good to me but I haven't tested them. Do you mind if I review and test this and the baroclinic gyre PR together, or do you have another idea in mind? |
|
@cbegeman whatever works better for you. Xylar and I had talked about making a separate branch and PR for the vertical grid changes, but since most of the changes were already updated by Xylar, this PR may be overkill. |
|
@alicebarthel, yes, exactly. I thought the renaming still needed to happen but that's already on |
|
No worries. I started the dev on a separate branch based on this (and rebased on yesterday's master). So maybe I'll switch this to a draft PR and make a bigger PR with the test case when I am ready. |
|
You don't need to make a new PR for the test case, you just need to force-push to the branch you used for #547. I would prefer that to a new PR. |
Added option for linearly increasing dz in the ocean vertical grid (needed for the baroclinic gyre case)
Checklist
api.rst) has any new or modified class, method and/or functions listedE3SM-Projectsubmodule has been updated with relevant E3SM changesMALI-Devsubmodule has been updated with relevant MALI changesTestingin this PR) any testing that was used to verify the changes