Skip to content

More verbose error when no TID found#1735

Open
bonventre wants to merge 2 commits intoMu2e:mainfrom
bonventre:nodefault
Open

More verbose error when no TID found#1735
bonventre wants to merge 2 commits intoMu2e:mainfrom
bonventre:nodefault

Conversation

@bonventre
Copy link
Contributor

No description provided.

@FNALbuild
Copy link
Collaborator

Hi @bonventre,
You have proposed changes to files in these packages:

  • DbService

which require these tests: build.

@Mu2e/write, @Mu2e/fnalbuild-users have access to CI actions on main.

⌛ The following tests have been triggered for 0cb1dca: build (Build queue - API unavailable)

About FNALbuild. Code review on Mu2e/Offline.

@FNALbuild
Copy link
Collaborator

☀️ The build tests passed at 0cb1dca.

Test Result Details
test with Command did not list any other PRs to include
merge Merged 0cb1dca at 35b6176
build (prof) Log file. Build time: 04 min 09 sec
ceSimReco Log file.
g4test_03MT Log file.
transportOnly Log file.
POT Log file.
g4study Log file.
cosmicSimReco Log file.
cosmicOffSpill Log file.
ceSteps Log file.
ceDigi Log file.
muDauSteps Log file.
ceMix Log file.
rootOverlaps Log file.
g4surfaceCheck Log file.
trigger Log file.
check_cmake Log file.
FIXME, TODO TODO (0) FIXME (0) in 2 files
clang-tidy 0 errors 0 warnings
whitespace check no whitespace errors found

N.B. These results were obtained from a build of this Pull Request at 0cb1dca after being merged into the base branch at 35b6176.

For more information, please check the job page here.
Build artifacts are deleted after 5 days. If this is not desired, select Keep this build forever on the job page.

Copy link
Collaborator

@rlcee rlcee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@oksuzian
Copy link
Collaborator

cet::exception streams are not std::ostream objects in the traditional sense. Using std::endl (which flushes the stream buffer) may not behave as intended, or worse, may fail to compile depending on the cet::exception implementation. The conventional pattern with cet::exception is to use the newline character "\n" instead.

@FNALbuild
Copy link
Collaborator

📝 The HEAD of main has changed to 32f8cbc. Tests are now out of date.

@oksuzian
Copy link
Collaborator

@FNALbuild run build test

@FNALbuild
Copy link
Collaborator

⌛ The following tests have been triggered for 03b1b4b: build (Build queue - API unavailable)

@FNALbuild
Copy link
Collaborator

☀️ The build tests passed at 03b1b4b.

Test Result Details
test with Command did not list any other PRs to include
merge Merged 03b1b4b at a2a2227
build (prof) Log file. Build time: 08 min 48 sec
ceSimReco Log file.
g4test_03MT Log file.
transportOnly Log file.
POT Log file.
g4study Log file.
cosmicSimReco Log file.
cosmicOffSpill Log file.
ceSteps Log file.
ceDigi Log file.
muDauSteps Log file.
ceMix Log file.
rootOverlaps Log file.
g4surfaceCheck Log file.
trigger Log file.
check_cmake Log file.
FIXME, TODO TODO (0) FIXME (0) in 2 files
clang-tidy 0 errors 0 warnings
whitespace check no whitespace errors found

N.B. These results were obtained from a build of this Pull Request at 03b1b4b after being merged into the base branch at a2a2227.

For more information, please check the job page here.
Build artifacts are deleted after 5 days. If this is not desired, select Keep this build forever on the job page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Comments