ELI-626 related bugfix (example selector partial matching) and rationalise example identifiers to 10 digits#351
Merged
jhadfield-NHS merged 3 commits intomainfrom Feb 9, 2026
Conversation
Reduce all example references to 10 digit length (to match updated spec) and appended the parameter separator when looking for an example mapping to prevent shorter requested numbers matching a longer example number.
eddalmond1
approved these changes
Feb 9, 2026
…rs-and-fix-selector
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Modify the example header selector to prevent partial matches e.g. 5000000001 matching where 50000000011 requested.
Also reducing the example identifiers and associated mappings to use 10 digits (to be NHS Number format conmsistent)
Context
Confusing results were occuring in some cases where 11 digit values were supplied.
Type of changes
Checklist
Sensitive Information Declaration
To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.