#4448 - Validate --saveEngine path before engine build#4675
Closed
AditiThirdEye wants to merge 1 commit intoNVIDIA:mainfrom
Closed
#4448 - Validate --saveEngine path before engine build#4675AditiThirdEye wants to merge 1 commit intoNVIDIA:mainfrom
AditiThirdEye wants to merge 1 commit intoNVIDIA:mainfrom
Conversation
Add early validation of the --saveEngine output path to fail fast when the path is invalid or unwritable, avoiding wasted computation. This change adds a canWriteFile() utility function that: - Checks if the parent directory exists - Tests write permissions by creating a temporary file - Cleans up the temporary file after testing The validation runs immediately when --saveEngine is parsed, before any expensive ONNX parsing or engine building operations. Signed-off-by: Aditi_Pandey <54734131+AditiThirdEye@users.noreply.github.com>
Author
|
Closing in favor of #4449 which implements the same approach and was submitted first. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add early validation of the --saveEngine output path to fail fast when the path is invalid or unwritable, avoiding wasted computation.
This change adds a canWriteFile() utility function that:
The validation runs immediately when --saveEngine is parsed, before any expensive ONNX parsing or engine building operations.