Skip to content

Conversation

@philiptaron
Copy link
Contributor

The situation of #217 with no merge happening because of incorrect paperwork -- even though it's just documenting a change that already happened -- is ridiculous. Let's fix that.

…cumentation file

The situation of #217 with no merge happening because of incorrect paperwork -- even though it's just documenting a change that already happened -- is *ridiculous*. Let's fix that.
@philiptaron philiptaron requested review from a team as code owners December 9, 2025 00:17
@mweinelt
Copy link
Member

mweinelt commented Dec 9, 2025

How about allowing the SC to bypass branch protection by ticking the box instead?

@philiptaron
Copy link
Contributor Author

That's a sensible change to make. I don't have access to make that change. Hence the ridiculousness circularity.

@infinisil
Copy link
Member

@philiptaron The idea of this repo is that it reflects the very distributed nature of who owns what. Code ownership should mirror who can actually affect the resources, because they are the ones who will have to implement changes to those resources. This all only works if the people with access actually maintain the documentation and keep it in sync with reality though.

The fact that we can't merge #217 is merely a symptom of the code owners of that file not maintaining it. The solution should be to change the code owners of that file, and the owners of the calendar with it.

Instead the main effect you get from adding the SC everywhere is that 7 more people get notifications for every PR in this repo, which robs everybody's attention, while diluting and centralising responsibility, and ignoring that the calendar and its docs is not being maintained by those with access to it.

@philiptaron
Copy link
Contributor Author

Why are you making it more difficult to do that?! Please click some button so that we can do that!

@philiptaron
Copy link
Contributor Author

I'm ticked off at your request to keep the docs up to date, then not clicking the button to merge the docs when they were updated. I don't care about CODEOWNERS files! I don't care about grain-of-rice-by-grain-of-rice permissions on files in this repo! I care about the documentation for NixOS governance being kept up to date, and because even the steering committee doesn't have rights to do that, of course it's not being kept up to date!

It should not require six different attention switches and private reach-outs and delays to do this. It should just have been git push.

@infinisil
Copy link
Member

infinisil commented Dec 9, 2025

I would've appreciated a more level-headed discussion, but okay, I turned off the code-owner-required check, so anybody with merge access can now merge any PR. I agree that that made some changes annoying, even though I liked the concept of it.

@infinisil infinisil closed this Dec 9, 2025
@wolfgangwalther wolfgangwalther deleted the SC-owners branch December 9, 2025 09:01
@wolfgangwalther
Copy link
Contributor

I turned off the code-owner-required check, so anybody with merge access can now merge any PR

Thank you, that makes managing the branch protection rules easier as well, because I don't need an after-the-fact approval of another core team member, when I put up a PR myself - which was a bit annoying as well.

@philiptaron
Copy link
Contributor Author

Thanks @infinisil.

philiptaron added a commit that referenced this pull request Dec 10, 2025
philiptaron added a commit that referenced this pull request Dec 10, 2025
philiptaron added a commit that referenced this pull request Dec 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants