[FIX] SQL Level 5, variable should not be inside string single-quotes#14
Open
lacksfish wants to merge 1 commit intoOWASP:masterfrom
Open
[FIX] SQL Level 5, variable should not be inside string single-quotes#14lacksfish wants to merge 1 commit intoOWASP:masterfrom
lacksfish wants to merge 1 commit intoOWASP:masterfrom
Conversation
Author
|
I'm contemplating what that line should've looked like Possible intentions could have been:
I've also thought about this possibility: Either way, the current line is bugged, since it is taking $number as the literal string input each time. |
|
Thank you 👍🏻 I encountered the same issue. None of my static/dynamic scanners were able to spot the vulnerability because there is none. '$number' is not user-controlled data. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Line 50
$query = "SELECT bookname,authorname FROM books WHERE number =".'$number';in
sql5.phpwill never work, as'$number'is a string.Asuming this was an error, this PR fixes this issue.