core: log error when bcast proposal#4240
Conversation
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4240 +/- ##
==========================================
- Coverage 57.03% 56.96% -0.07%
==========================================
Files 237 237
Lines 30857 30864 +7
==========================================
- Hits 17599 17582 -17
- Misses 11021 11043 +22
- Partials 2237 2239 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| z.Bool("blinded", block.Blinded), | ||
| ) | ||
| } else { | ||
| log.Error(ctx, "Failed to submit block proposal to beacon node", |
There was a problem hiding this comment.
We will log a failed BN call if there is an error, as we will return error from this endpoint
There was a problem hiding this comment.
Yes but we won't log details such as "blinded"
There was a problem hiding this comment.
Hmmm okay. This will become obsolete in Gloas fork, but we can make some use of it until then.
| z.Bool("blinded", block.Blinded), | ||
| ) | ||
| } else { | ||
| log.Error(ctx, "Failed to submit block proposal to beacon node", |
There was a problem hiding this comment.
Hmmm okay. This will become obsolete in Gloas fork, but we can make some use of it until then.
pinebit
added
the
merge when ready
3 participants
Added logging error if bcast failed to submit proposal.
category: refactor
ticket: none