-
Notifications
You must be signed in to change notification settings - Fork 425
feat: lsp-progress #2649
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
feat: lsp-progress #2649
Changes from 1 commit
56dadd8
e91885e
ffa03c9
0902f18
bb7a873
05e315d
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2,6 +2,7 @@ namespace OmniSharp.Models.Events | |
| { | ||
| public static class EventTypes | ||
| { | ||
| public const string ProjectLoadingStarted = nameof(ProjectLoadingStarted); | ||
|
||
| public const string ProjectAdded = nameof(ProjectAdded); | ||
| public const string ProjectChanged = nameof(ProjectChanged); | ||
| public const string ProjectRemoved = nameof(ProjectRemoved); | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,4 @@ | ||
| using System.Collections.Concurrent; | ||
| using System.Linq; | ||
| using Microsoft.Extensions.DependencyInjection; | ||
| using Newtonsoft.Json; | ||
|
|
@@ -6,6 +7,7 @@ | |
| using OmniSharp.Extensions.LanguageServer.Protocol.Document; | ||
| using OmniSharp.Extensions.LanguageServer.Protocol.Models; | ||
| using OmniSharp.Extensions.LanguageServer.Protocol.Server; | ||
| using OmniSharp.Extensions.LanguageServer.Protocol.Server.WorkDone; | ||
| using OmniSharp.LanguageServerProtocol.Handlers; | ||
| using OmniSharp.Models.Diagnostics; | ||
| using OmniSharp.Models.Events; | ||
|
|
@@ -16,6 +18,8 @@ public class LanguageServerEventEmitter : IEventEmitter | |
| { | ||
| private readonly ILanguageServer _server; | ||
| private readonly DocumentVersions _documentVersions; | ||
| private readonly ConcurrentDictionary<string, IWorkDoneObserver> _projectObservers = new(); | ||
| private IWorkDoneObserver _restoreObserver; | ||
|
|
||
| public LanguageServerEventEmitter(ILanguageServer server) | ||
| { | ||
|
|
@@ -46,6 +50,14 @@ public void Emit(string kind, object args) | |
| } | ||
| } | ||
| break; | ||
| case EventTypes.ProjectLoadingStarted: | ||
| string projectPath = (string)args; | ||
| IWorkDoneObserver projectObserver = _server.WorkDoneManager | ||
| .Create(new WorkDoneProgressBegin { Title = $"Loading {projectPath}" }) | ||
| .GetAwaiter() | ||
|
||
| .GetResult(); | ||
| _projectObservers.TryAdd(projectPath, projectObserver); | ||
| break; | ||
| case EventTypes.ProjectAdded: | ||
| case EventTypes.ProjectChanged: | ||
| case EventTypes.ProjectRemoved: | ||
|
|
@@ -54,13 +66,31 @@ public void Emit(string kind, object args) | |
|
|
||
| // work done?? | ||
| case EventTypes.PackageRestoreStarted: | ||
| _server.SendNotification($"o#/{kind}".ToLowerInvariant(), JToken.FromObject(args)); | ||
| _restoreObserver = _server.WorkDoneManager | ||
| .Create(new WorkDoneProgressBegin { Title = "Restoring" }) | ||
| .GetAwaiter() | ||
| .GetResult(); | ||
| break; | ||
| case EventTypes.PackageRestoreFinished: | ||
| _server.SendNotification($"o#/{kind}".ToLowerInvariant(), JToken.FromObject(args)); | ||
| _restoreObserver.OnNext(new WorkDoneProgressReport { Message = "Restored" }); | ||
| _restoreObserver.OnCompleted(); | ||
| break; | ||
| case EventTypes.UnresolvedDependencies: | ||
| _server.SendNotification($"o#/{kind}".ToLowerInvariant(), JToken.FromObject(args)); | ||
| break; | ||
|
|
||
| case EventTypes.Error: | ||
| case EventTypes.ProjectConfiguration: | ||
| _server.SendNotification($"o#/{kind}".ToLowerInvariant(), JToken.FromObject(args)); | ||
| ProjectConfigurationMessage projectMessage = (ProjectConfigurationMessage)args; | ||
| if (_projectObservers.TryGetValue(projectMessage.ProjectFilePath, out IWorkDoneObserver obs)) | ||
| { | ||
| obs.OnNext(new WorkDoneProgressReport { Message = $"Loaded {projectMessage.ProjectFilePath}" }); | ||
| obs.OnCompleted(); | ||
| } | ||
| break; | ||
| case EventTypes.ProjectDiagnosticStatus: | ||
| _server.SendNotification($"o#/{kind}".ToLowerInvariant(), JToken.FromObject(args)); | ||
| break; | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The ProjectConfigurationMessage is used for some rudimentary telemetry. Passing ProjectFilePath may include some PII. Instead of using this message you would likely want to add a new Message type for ProjectLoadFinished.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.