Conversation
duxbay and oni and open-network-insight and all such variations renamed to "spot"
Open Network Insight => Apache Spot (incubating) in the readme and install files.
rabarona
left a comment
rabarona
left a comment
There was a problem hiding this comment.
Please review my comments and let me know what you think.
| @@ -1,3 +0,0 @@ | |||
| [submodule "oni-lda-c"] | |||
| path = oni-lda-c | |||
| url = https://github.com/OpenNetworkInsight/oni-lda-c | |||
There was a problem hiding this comment.
I'm not sure why to remove for the oni to spot change. I think this change corresponds to changing repos structure o renaming repos. This is eliminating the recursivity of ml and lda, right?
My point is we never sync .gitmodules file. After repo restructure we can git pull and everything should be in order.
There was a problem hiding this comment.
dammit
this was not supposed to be removed
not sure why the file got blown away
There was a problem hiding this comment.
hell, in my current repo I can't even add this file to git, it's being ignored...
something is weird
There was a problem hiding this comment.
i added this back in
| Install and configure oni-ml as a part of the Open-Network-Insight project, per the instruction at | ||
| [the Open-Network-Insight wiki](https://github.com/Open-Network-Insight/open-network-insight/wiki). | ||
| Install and configure spot-ml as a part of the Spot project, per the instruction at | ||
| [the Spot wiki]. |
There was a problem hiding this comment.
So, for now you are just keeping links placeholders rather than let them point to the current repo structure?
There was a problem hiding this comment.
yeah
will add new repo structure when it all comes on line
| @@ -1,4 +1,4 @@ | |||
| package org.opennetworkinsight | |||
| package org.spot | |||
There was a problem hiding this comment.
Is this the case where we need to use apache in the package name? Or is that happening after incubating process?
org.apache.spot?
There was a problem hiding this comment.
good question...
There was a problem hiding this comment.
apache beam does it (eg. org.apache.beam...)
There was a problem hiding this comment.
the incubating project "Apache Rya (incubating)" does not do it
so I guess there is flexibility
There was a problem hiding this comment.
thumbs up for which option?
There was a problem hiding this comment.
I like that too
🐶
update of ml_ops.sh finally added the util script upload.sh to git
replacing blown away .gitmodules file
org.spot => org.apache.spot Oh Yeah....
ml_ops.sh
Outdated
| ${MPI_PREP_CMD} | ||
|
|
||
| time spark-submit --class "org.opennetworkinsight.SuspiciousConnects" \ | ||
| time spark-submit --class "org.spot.SuspiciousConnects" \ |
rabarona
left a comment
rabarona
left a comment
There was a problem hiding this comment.
I'm not sure about upload.sh being in the repo.
upload.sh
Outdated
| # exclude the hidden files, target, lib, project, src... except the assembled jar | ||
| rsync $4 -v -a --include='target' --include='target/scala-2.10' --include='target/scala-2.10/*.jar' \ | ||
| --include='spot-lda-c' --include='spot-lda-c/*' --include='*.py' --include='*.sh' --include 'top-1m.csv' \ | ||
| --exclude='*' . $USER@$CLUSTER:~/$DIRNAME |
There was a problem hiding this comment.
Should this file be part of the project?
There was a problem hiding this comment.
on one hand:
people would almost certainly use it and appreciate it
on the other:
there is a process for adding stuff to the product and we didn't follow it
there's no documentation for it
There was a problem hiding this comment.
so I'm taking it out
on second thought, upload.sh won't be added to git at this time
|
LGTM |
2 participants
No description provided.