Fix: show real SP name on error pages when SP is a trusted proxy#1918
Open
kayjoosten wants to merge 1 commit intomainfrom
Open
Fix: show real SP name on error pages when SP is a trusted proxy#1918kayjoosten wants to merge 1 commit intomainfrom
kayjoosten wants to merge 1 commit intomainfrom
Conversation
When a request goes through a trusted proxy SP, store the real (proxied)
SP entity ID in $_SESSION['currentServiceProvider'] so error pages
(e.g. PEP denial) display the correct SP name instead of the proxy's name.
Also:
- Add unit tests for the trusted proxy session variable behaviour
- Fix undefined array key warning in FeedbackController::getFeedbackInfo()
- Add extra_hosts to docker-compose to prevent devconf HAProxy from
intercepting Behat requests during local development
Contributor
|
I'm a little uncomfortable with the naming convention here, because from a SAML POV the stepup-gateway is the real SP (the one we're directly communicating with) and selfservice is the proxied SP (the one the real SP is communicating about on behalf of the proxied SP). I'm not sure how SURF sees this, but I'm worried this might cause confusion in the future. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a request goes through a trusted proxy SP, store the real (proxied)
SP entity ID in $_SESSION['currentServiceProvider'] so error pages
(e.g. PEP denial) display the correct SP name instead of the proxy's name.
Also:
before:
after:
solves: issue 1778