OpenMage · sreichel · Dec 5, 2025 · Dec 5, 2025 · Dec 5, 2025 · Dec 5, 2025
diff --git a/.rector.php b/.rector.php
@@ -152,7 +152,7 @@
             instanceOf: true,
             earlyReturn: true,
             strictBooleans: false,
-            carbon: false,
+            carbon: true,
             rectorPreset: true,
             phpunitCodeQuality: true,
             doctrineCodeQuality: false,

diff --git a/app/Mage.php b/app/Mage.php
@@ -7,6 +7,7 @@
  * @package    Mage
  */
 
+use Carbon\Carbon;
 use Monolog\Formatter\LineFormatter;
 use Monolog\Handler\StreamHandler;
 use Monolog\Level;
@@ -857,7 +858,7 @@ public static function isInstalled($options = [])
             if (is_readable($localConfigFile)) {
                 $localConfig = simplexml_load_file($localConfigFile);
                 date_default_timezone_set('UTC');
-                if (($date = $localConfig->global->install->date) && strtotime((string) $date)) {
+                if (($date = $localConfig->global->install->date) && Carbon::parse((string) $date)->getTimestamp()) {
                     self::$_isInstalled = true;
                 }
             }

diff --git a/app/code/core/Mage/AdminNotification/Model/Feed.php b/app/code/core/Mage/AdminNotification/Model/Feed.php
@@ -7,6 +7,8 @@
  * @package    Mage_AdminNotification
  */
 
+use Carbon\Carbon;
+
 /**
  * AdminNotification Feed model
  *
@@ -55,7 +57,7 @@ public function getFeedUrl()
      */
     public function checkUpdate()
     {
-        if (($this->getFrequency() + $this->getLastUpdate()) > time()) {
+        if (($this->getFrequency() + $this->getLastUpdate()) > Carbon::now()->getTimestamp()) {
             return $this;
         }
 
@@ -92,7 +94,7 @@ public function checkUpdate()
      */
     public function getDate($rssDate)
     {
-        return gmdate(Varien_Db_Adapter_Pdo_Mysql::TIMESTAMP_FORMAT, strtotime($rssDate));
+        return gmdate(Varien_Db_Adapter_Pdo_Mysql::TIMESTAMP_FORMAT, Carbon::parse($rssDate)->getTimestamp());
     }
 
     /**
@@ -122,7 +124,7 @@ public function getLastUpdate()
      */
     public function setLastUpdate()
     {
-        Mage::app()->saveCache(time(), 'admin_notifications_lastcheck');
+        Mage::app()->saveCache(Carbon::now()->getTimestamp(), 'admin_notifications_lastcheck');
         return $this;
     }
 

diff --git a/app/code/core/Mage/Adminhtml/Block/Customer/Edit/Tab/View.php b/app/code/core/Mage/Adminhtml/Block/Customer/Edit/Tab/View.php
@@ -7,6 +7,8 @@
  * @package    Mage_Adminhtml
  */
 
+use Carbon\Carbon;
+
 /**
  * Customer account form block
  *
@@ -139,7 +141,7 @@ public function getCurrentStatus()
         $log = $this->getCustomerLog();
         if ($log->getLogoutAt()
             || !$log->getLastVisitAt()
-            || strtotime(Varien_Date::now()) - strtotime($log->getLastVisitAt()) > Mage_Log_Model_Visitor::getOnlineMinutesInterval() * 60
+            || Carbon::parse(Varien_Date::now())->getTimestamp() - Carbon::parse($log->getLastVisitAt())->getTimestamp() > Mage_Log_Model_Visitor::getOnlineMinutesInterval() * 60
         ) {
             return Mage::helper('customer')->__('Offline');
         }

diff --git a/app/code/core/Mage/Adminhtml/Block/Dashboard/Graph.php b/app/code/core/Mage/Adminhtml/Block/Dashboard/Graph.php
@@ -8,6 +8,8 @@
  * @package    Mage_Adminhtml
  */
 
+use Carbon\Carbon;
+
 /**
  * Adminhtml dashboard google chart block
  *
@@ -215,7 +217,7 @@ public function generateChart(): array
                             $formats = Mage::app()->getLocale()->getTranslationList('datetime');
                             $format = $formats['yyMM'] ?? 'MM/yyyy';
                             $format = str_replace(['yyyy', 'yy', 'MM'], ['Y', 'y', 'm'], $format);
-                            $this->_axisLabels[$idx][$_index] = date($format, strtotime($_label));
+                            $this->_axisLabels[$idx][$_index] = Carbon::parse($_label)->format($format);
                             break;
                     }
                 }

diff --git a/app/code/core/Mage/Adminhtml/Block/Sales/Transactions/Detail.php b/app/code/core/Mage/Adminhtml/Block/Sales/Transactions/Detail.php
@@ -7,6 +7,7 @@
  * @package    Mage_Adminhtml
  */
 
+use Carbon\Carbon;
 
 /**
  * Adminhtml transaction detail
@@ -97,7 +98,7 @@ protected function _toHtml()
             ($this->_txn->getIsClosed()) ? Mage::helper('sales')->__('Yes') : Mage::helper('sales')->__('No'),
         );
 
-        $createdAt = (strtotime($this->_txn->getCreatedAt()))
+        $createdAt = (Carbon::parse($this->_txn->getCreatedAt())->getTimestamp())
             ? $this->formatDate($this->_txn->getCreatedAt(), Mage_Core_Model_Locale::FORMAT_TYPE_MEDIUM, true)
             : $this->__('N/A');
         $this->setCreatedAtHtml($this->escapeHtml($createdAt));

diff --git a/app/code/core/Mage/Adminhtml/Block/Sitemap/Grid/Renderer/Time.php b/app/code/core/Mage/Adminhtml/Block/Sitemap/Grid/Renderer/Time.php
@@ -7,6 +7,8 @@
  * @package    Mage_Adminhtml
  */
 
+use Carbon\Carbon;
+
 /**
  * Sitemap grid link column renderer
  *
@@ -21,9 +23,6 @@ class Mage_Adminhtml_Block_Sitemap_Grid_Renderer_Time extends Mage_Adminhtml_Blo
      */
     public function render(Varien_Object $row)
     {
-        return date(
-            Varien_Date::DATETIME_PHP_FORMAT,
-            strtotime($row->getSitemapTime()) + Mage::getSingleton('core/date')->getGmtOffset(),
-        );
+        return Carbon::createFromTimestamp(Carbon::parse($row->getSitemapTime())->getTimestamp() + Mage::getSingleton('core/date')->getGmtOffset())->format(Varien_Date::DATETIME_PHP_FORMAT);
     }
 }
diff --git a/app/code/core/Mage/Adminhtml/Block/System/Config/Form/Field/Import.php b/app/code/core/Mage/Adminhtml/Block/System/Config/Form/Field/Import.php
@@ -7,6 +7,8 @@
  * @package    Mage_Adminhtml
  */
 
+use Carbon\Carbon;
+
 /**
  * Custom import CSV file field for shipping table rates
  *
@@ -30,7 +32,7 @@ public function getElementHtml()
     {
         $html = '';
 
-        $html .= '<input id="time_condition" type="hidden" name="' . $this->getName() . '" value="' . time() . '" />';
+        $html .= '<input id="time_condition" type="hidden" name="' . $this->getName() . '" value="' . Carbon::now()->getTimestamp() . '" />';
 
         $html .= <<<EndHTML
         <script type="text/javascript">

diff --git a/app/code/core/Mage/Adminhtml/Model/Sales/Order/Create.php b/app/code/core/Mage/Adminhtml/Model/Sales/Order/Create.php
@@ -7,6 +7,8 @@
  * @package    Mage_Adminhtml
  */
 
+use Carbon\Carbon;
+
 /**
  * Order create model
  *
@@ -1705,7 +1707,7 @@ protected function _getNewCustomerEmail($customer)
             $host = $this->getSession()
                 ->getStore()
                 ->getConfig(Mage_Customer_Model_Customer::XML_PATH_DEFAULT_EMAIL_DOMAIN);
-            $account = $customer->getIncrementId() ? $customer->getIncrementId() : time();
+            $account = $customer->getIncrementId() ? $customer->getIncrementId() : Carbon::now()->getTimestamp();
             $email = $account . '@' . $host;
             $account = $this->getData('account');
             $account['email'] = $email;

diff --git a/app/code/core/Mage/Adminhtml/Model/Sales/Order/Random.php b/app/code/core/Mage/Adminhtml/Model/Sales/Order/Random.php
@@ -7,6 +7,8 @@
  * @package    Mage_Adminhtml
  */
 
+use Carbon\Carbon;
+
 /**
  * Create random order
  *
@@ -148,7 +150,7 @@ public function render()
     protected function _getRandomDate()
     {
         $timestamp = mktime(random_int(0, 23), random_int(0, 59), 0, random_int(1, 11), random_int(1, 28), random_int(2006, 2007));
-        return date(Varien_Date::DATETIME_PHP_FORMAT, $timestamp);
+        return Carbon::createFromTimestamp($timestamp)->format(Varien_Date::DATETIME_PHP_FORMAT);
     }
 
     public function save()

diff --git a/app/code/core/Mage/Adminhtml/Model/System/Config/Source/Date/Short.php b/app/code/core/Mage/Adminhtml/Model/System/Config/Source/Date/Short.php
@@ -7,6 +7,8 @@
  * @package    Mage_Adminhtml
  */
 
+use Carbon\Carbon;
+
 /**
  * @package    Mage_Adminhtml
  * @deprecated
@@ -17,10 +19,10 @@ public function toOptionArray()
     {
         return [
             ['label' => '', 'value' => ''],
-            ['label' => sprintf('MM/DD/YY (%s)', date('m/d/y')), 'value' => '%m/%d/%y'],
-            ['label' => sprintf('MM/DD/YYYY (%s)', date('m/d/Y')), 'value' => '%m/%d/%Y'],
-            ['label' => sprintf('DD/MM/YY (%s)', date('d/m/y')), 'value' => '%d/%m/%y'],
-            ['label' => sprintf('DD/MM/YYYY (%s)', date('d/m/Y')), 'value' => '%d/%m/%Y'],
+            ['label' => sprintf('MM/DD/YY (%s)', Carbon::now()->format('m/d/y')), 'value' => '%m/%d/%y'],
+            ['label' => sprintf('MM/DD/YYYY (%s)', Carbon::now()->format('m/d/Y')), 'value' => '%m/%d/%Y'],
+            ['label' => sprintf('DD/MM/YY (%s)', Carbon::now()->format('d/m/y')), 'value' => '%d/%m/%y'],
+            ['label' => sprintf('DD/MM/YYYY (%s)', Carbon::now()->format('d/m/Y')), 'value' => '%d/%m/%Y'],
         ];
     }
 }
diff --git a/app/code/core/Mage/Adminhtml/controllers/CustomerController.php b/app/code/core/Mage/Adminhtml/controllers/CustomerController.php
@@ -7,6 +7,8 @@
  * @package    Mage_Adminhtml
  */
 
+use Carbon\Carbon;
+
 /**
  * Customer admin controller
  *
@@ -334,7 +336,7 @@ public function saveAction()
                 // Force new customer confirmation
                 if ($isNewCustomer) {
                     $customer->setPassword($data['account']['password']);
-                    $customer->setPasswordCreatedAt(time());
+                    $customer->setPasswordCreatedAt(Carbon::now()->getTimestamp());
                     $customer->setForceConfirmed(true);
                     if ($customer->getPassword() === 'auto') {
                         $sendPassToEmail = true;
@@ -886,7 +888,7 @@ public function viewfileAction()
                 ->setHeader('Pragma', 'public', true)
                 ->setHeader('Content-type', $contentType, true)
                 ->setHeader('Content-Length', $contentLength)
-                ->setHeader('Last-Modified', date('r', (int) $contentModify))
+                ->setHeader('Last-Modified', Carbon::createFromTimestamp((int) $contentModify)->format('r'))
                 ->clearBody();
             $this->getResponse()->sendHeaders();
 

diff --git a/app/code/core/Mage/Adminhtml/controllers/Sales/Order/ShipmentController.php b/app/code/core/Mage/Adminhtml/controllers/Sales/Order/ShipmentController.php
@@ -7,6 +7,8 @@
  * @package    Mage_Adminhtml
  */
 
+use Carbon\Carbon;
+
 /**
  * Adminhtml sales order shipment controller
  *
@@ -758,7 +760,7 @@ protected function _createPdfPageFromImageString($imageString)
 
         imageinterlace($image, false);
         $tmpFileName = sys_get_temp_dir() . DS . 'shipping_labels_'
-                     . uniqid((string) mt_rand()) . time() . '.png';
+                     . uniqid((string) mt_rand()) . Carbon::now()->getTimestamp() . '.png';
         imagepng($image, $tmpFileName);
         $pdfImage = Zend_Pdf_Image::imageWithPath($tmpFileName);
         $page->drawImage($pdfImage, 0, 0, $xSize, $ySize);

diff --git a/app/code/core/Mage/Adminhtml/controllers/System/Config/System/StorageController.php b/app/code/core/Mage/Adminhtml/controllers/System/Config/System/StorageController.php
@@ -7,6 +7,8 @@
  * @package    Mage_Adminhtml
  */
 
+use Carbon\Carbon;
+
 /**
  * Adminhtml account controller
  *
@@ -56,7 +58,7 @@ public function synchronizeAction()
         $flag = $this->_getSyncFlag();
         if ($flag && $flag->getState() == Mage_Core_Model_File_Storage_Flag::STATE_RUNNING
             && $flag->getLastUpdate()
-            && time() <= (strtotime($flag->getLastUpdate()) + Mage_Core_Model_File_Storage_Flag::FLAG_TTL)
+            && Carbon::now()->getTimestamp() <= (Carbon::parse($flag->getLastUpdate())->getTimestamp() + Mage_Core_Model_File_Storage_Flag::FLAG_TTL)
         ) {
             return;
         }
@@ -103,7 +105,7 @@ public function statusAction()
                     break;
                 case Mage_Core_Model_File_Storage_Flag::STATE_RUNNING:
                     if (!$flag->getLastUpdate()
-                        || time() <= (strtotime($flag->getLastUpdate()) + Mage_Core_Model_File_Storage_Flag::FLAG_TTL)
+                        || Carbon::now()->getTimestamp() <= (Carbon::parse($flag->getLastUpdate())->getTimestamp() + Mage_Core_Model_File_Storage_Flag::FLAG_TTL)
                     ) {
                         $flagData = $flag->getFlagData();
                         if (is_array($flagData)

diff --git a/app/code/core/Mage/Adminhtml/controllers/System/StoreController.php b/app/code/core/Mage/Adminhtml/controllers/System/StoreController.php
@@ -7,6 +7,8 @@
  * @package    Mage_Adminhtml
  */
 
+use Carbon\Carbon;
+
 /**
  * Store controller
  *
@@ -480,7 +482,7 @@ protected function _backupDatabase($failPath, $arguments = [])
         try {
             $backupDb = Mage::getModel('backup/db');
             $backup   = Mage::getModel('backup/backup')
-                ->setTime(time())
+                ->setTime(Carbon::now()->getTimestamp())
                 ->setType('db')
                 ->setPath(Mage::getBaseDir('var') . DS . 'backups');
 

diff --git a/app/code/core/Mage/Api/Model/Session.php b/app/code/core/Mage/Api/Model/Session.php
@@ -7,6 +7,8 @@
  * @package    Mage_Api
  */
 
+use Carbon\Carbon;
+
 /**
  * Webservice api session
  *
@@ -29,7 +31,7 @@ class Mage_Api_Model_Session extends Mage_Core_Model_Session_Abstract
      */
     public function start($sessionName = null)
     {
-        $this->_currentSessId = md5(time() . uniqid('', true) . $sessionName);
+        $this->_currentSessId = md5(Carbon::now()->getTimestamp() . uniqid('', true) . $sessionName);
         $this->sessionIds[] = $this->getSessionId();
         return $this;
     }
@@ -217,7 +219,7 @@ public function isSessionExpired($user)
             return true;
         }
 
-        $timeout = strtotime(Varien_Date::now()) - strtotime($user->getLogdate());
+        $timeout = Carbon::parse(Varien_Date::now())->getTimestamp() - Carbon::parse($user->getLogdate())->getTimestamp();
         return $timeout > Mage::getStoreConfig('api/config/session_timeout');
     }
 

diff --git a/app/code/core/Mage/Authorizenet/Model/Directpost/Request.php b/app/code/core/Mage/Authorizenet/Model/Directpost/Request.php
@@ -7,6 +7,8 @@
  * @package    Mage_Authorizenet
  */
 
+use Carbon\Carbon;
+
 /**
  * Authorize.net request model for DirectPost model.
  *
@@ -155,7 +157,7 @@ public function setDataFromOrder(Mage_Sales_Model_Order $order, Mage_Authorizene
      */
     public function signRequestData()
     {
-        $fpTimestamp = (string) time();
+        $fpTimestamp = (string) Carbon::now()->getTimestamp();
         $signatureKey = $this->_getSignatureKey();
         if (!empty($signatureKey)) {
             $hash = $this->_generateSha2RequestSign(

diff --git a/app/code/core/Mage/Captcha/Model/Observer.php b/app/code/core/Mage/Captcha/Model/Observer.php
@@ -7,6 +7,8 @@
  * @package    Mage_Captcha
  */
 
+use Carbon\Carbon;
+
 /**
  * Captcha Observer
  *
@@ -141,6 +143,7 @@ public function checkRegisterCheckout($observer)
      *
      * @param Varien_Event_Observer $observer
      * @return $this
+     * @throws Mage_Core_Exception
      */
     public function checkUserLoginBackend($observer)
     {
@@ -234,11 +237,13 @@ public function deleteOldAttempts()
      * Delete Expired Captcha Images
      *
      * @return $this
+     * @throws Mage_Core_Exception
      */
     public function deleteExpiredImages()
     {
         foreach (Mage::app()->getWebsites(true) as $website) {
-            $expire = time() - Mage::helper('captcha')->getConfigNode('timeout', $website->getDefaultStore()) * 60;
+            $timeout = (int) Mage::helper('captcha')->getConfigNode('timeout', $website->getDefaultStore());
+            $expire = Carbon::now()->subMinutes($timeout)->getTimestamp();
             $imageDirectory = Mage::helper('captcha')->getImgDir($website);
             foreach (new DirectoryIterator($imageDirectory) as $file) {
                 if ($file->isFile() && pathinfo($file->getFilename(), PATHINFO_EXTENSION) == 'png') {
@@ -320,13 +325,13 @@ public function checkSendfriendSend($observer)
                 Mage::getSingleton('catalog/session')->addError(Mage::helper('captcha')->__('Incorrect CAPTCHA.'));
                 $controller->setFlag('', Mage_Core_Controller_Varien_Action::FLAG_NO_DISPATCH, true);
                 Mage::getSingleton('catalog/session')->setFormData($request->getPost());
-                $id = (int) $request->getParam('id');
+                $sendId = (int) $request->getParam('id');
                 $catId = $request->getParam('cat_id');
                 if ($catId !== null) {
-                    $id .= '/cat_id/' . (int) $catId;
+                    $sendId .= '/cat_id/' . (int) $catId;
                 }
 
-                $controller->getResponse()->setRedirect(Mage::getUrl('*/*/send/id/' . $id));
+                $controller->getResponse()->setRedirect(Mage::getUrl('*/*/send/id/' . $sendId));
             }
         }