[ana6, com8]: Add ana6Optimisation Module, apply changes in com8MoTPSA by RolandFischbacher · Pull Request #1245 · OpenNHM/AvaFrame

RolandFischbacher · 2026-02-23T17:47:10Z

This PR introduces a new optimisation module ana6Optimisation for com8MoTPSA and updates the simulation workflow.

The module ana6Optimisation includes:

Calculation of combined loss function (runout + tversky)
Morris sensitivity analysis for parameter ranking
Sequential and non-sequential surrogate based optimisation routines

New files in ana6Opitmisaton:

runMorrisSA.py (configuration: runMorrisSACfg.ini)
runPlotMorrisConvergence.py (uses runMorrisSACfg.ini)
runOptimisation.py (configuration: runOptimisationCfg.ini)
optimisationUtils.py
README_ana6.md (contains usage instructions)

New file in out3Plot:

outAna6Plots.py

Changed workflow of runing com8MoTPSA:

Check prior if simulation is run already
Process in chunks not all simulations at once

qltysh · 2026-02-23T17:48:47Z

❌ 10 blocking issues (18 total)

Tool	Category	Rule	Count
prettier	Style	Incorrect formatting, autoformat by running `qlty fmt`.	7	❌
ripgrep	Lint	# NOTE: rmse/mae were returned as NEGATIVE numbers because the higher is better internally	1	❌
ruff	Lint	f-string without any placeholders	1	❌
ruff	Lint	Local variable `bars` is assigned to but never used	1	❌
qlty	Structure	Function with high complexity (count = 20): readParamSetDF	4
qlty	Structure	Deeply nested control flow (level = 4)	2
qlty	Structure	High total complexity (count = 82)	1
qlty	Structure	Function with many returns (count = 6): formatSig	1

@qltysh one-click actions:

Auto-fix formatting (qlty fmt && git push)

avaframe/ana3AIMEC/aimecTools.py

avaframe/ana6Optimisation/README_ana6.md

avaframe/ana6Optimisation/optimisationUtils.py

avaframe/out3Plot/outAna6Plots.py

qltysh · 2026-02-23T17:48:49Z

avaframe/out3Plot/outAna6Plots.py

+    # 4) Plot
+    x = np.arange(len(df))
+    fig, ax = plt.subplots(figsize=(12, 6))
+    bars = ax.bar(


Local variable bars is assigned to but never used [ruff:F841]

Suggested change

bars = ax.bar(

ax.bar(

qltysh · 2026-02-23T17:48:49Z

avaframe/out3Plot/outAna6Plots.py

+        tmp.insert(0, "table", t)
+        frames.append(tmp)
+    pd.concat(frames, ignore_index=True).to_csv(csv_path, index=False)
+


Function with high complexity (count = 36): saveTopCandidates [qlty:function-complexity]

qltysh · 2026-02-23T17:48:49Z

avaframe/out3Plot/outAna6Plots.py

+        return f"{x:.2e}"  # small numbers in scientific notation
+    elif abs(x) < 100:
+        return f"{x:.2g}"  # 2 significant digits
+    else:


Function with many returns (count = 6): formatSig [qlty:return-statements]

qltysh · 2026-02-23T17:48:49Z

avaframe/out3Plot/outAna6Plots.py

+    fig.tight_layout()
+
+    if outpath is not None:
+        fig.savefig(outpath, dpi=300, bbox_inches="tight")


High total complexity (count = 82) [qlty:file-complexity]

qltysh · 2026-02-23T17:56:11Z

avaframe/ana6Optimisation/optimisationUtils.py

@@ -0,0 +1,895 @@
+import numpy as np


Found 2 issues:

1. Incorrect formatting, autoformat by running qlty fmt. [black:fmt]

2. Incorrect formatting, autoformat by running qlty fmt. [ruff:fmt]

avaframe/ana6Optimisation/optimisationUtils.py

qltysh · 2026-02-23T17:56:11Z

avaframe/out3Plot/outAna6Plots.py

@@ -0,0 +1,918 @@
+import numpy as np


Found 2 issues:

1. Incorrect formatting, autoformat by running qlty fmt. [black:fmt]

2. Incorrect formatting, autoformat by running qlty fmt. [ruff:fmt]

avaframe/ana3AIMEC/aimecTools.py

avaframe/ana3AIMEC/ana3AIMEC.py

avaframe/out3Plot/outQuickPlot.py

qltysh · 2026-02-24T08:51:55Z

avaframe/ana6Optimisation/optimisationUtils.py

+                    index = config['VISUALISATION']['scenario']
+                    if 'sampleMethod' in config['VISUALISATION']:
+                        sampleMethod = config['VISUALISATION']['sampleMethod']
+                    else:


Deeply nested control flow (level = 4) [qlty:nested-control-flow]

avaframe/ana3AIMEC/aimecTools.py

qltysh · 2026-02-24T08:51:55Z

avaframe/ana6Optimisation/README_ana6.md

@@ -0,0 +1,140 @@
+# ana6 – Sensitivity Analysis & Optimisation


Incorrect formatting, autoformat by running qlty fmt. [prettier:fmt]

qltysh · 2026-02-24T08:51:55Z

avaframe/ana6Optimisation/optimisationUtils.py

+        'parameterSet': paramSet,  # [row for row in paramSet], # Wrap each row as a list
+        'order': pd.to_numeric(order),  # convert to int
+        'sampleMethods': sampleMethods
+    })


Function with high complexity (count = 20): readParamSetDF [qlty:function-complexity]

avaframe/com8MoTPSA/com8MoTPSA.py

avaframe/out1Peak/outPlotAllPeakDiffs.py

avaframe/out3Plot/outAIMEC.py

Squash of 20 commits from RF_com8MoTPSA branch including: - com8MoTPSA workflow improvements (chunked multiprocessing, path handling) - Bayesian optimisation integration (ana6Optimisation module) - Morris sensitivity analysis scripts - AIMEC runout reference implementation - probAna pickle saving and bounds - Plotting and config improvements

qltysh · 2026-02-24T14:37:29Z

avaframe/ana6Optimisation/optimisationUtils.py

+        error_score="raise"  # fail fast if something else is wrong
+    )
+
+    # NOTE: rmse/mae were returned as NEGATIVE numbers because the higher is better internally


# NOTE: rmse/mae were returned as NEGATIVE numbers because the higher is better internally [ripgrep:NOTE]

qltysh · 2026-02-24T14:37:30Z

avaframe/ana6Optimisation/optimisationUtils.py

+    print(f"📊 sigma: {best_sigma:.4f}")
+
+    return {
+        f"TopNBest": {


f-string without any placeholders [ruff:F541]

Suggested change

f"TopNBest": {

"TopNBest": {

qltysh · 2026-02-24T14:37:30Z

avaframe/com8MoTPSA/com8MoTPSA.py

+                # Delete folder in Work directory after postprocessing to reduce memory costs
+                avaDir = cfgMain["MAIN"]["avalancheDir"]
+                for sim in simNamesChunk:
+                    folderName = "Work/com8MoTPSA/" + sim


Deeply nested control flow (level = 4) [qlty:nested-control-flow]

qltysh · 2026-02-24T14:37:30Z

avaframe/com8MoTPSA/com8MoTPSA.py


-    # Postprocess the simulations
-    com8MoTPSAPostprocess(simDict, cfgMain, inputSimFiles)
+    if returnSimName is not None and simDict:


Function with high complexity (count = 18): com8MoTPSAMain [qlty:function-complexity]

qltysh · 2026-02-24T14:41:27Z

Coverage Impact

⬇️ Merging this pull request will decrease total coverage on master by 0.19%.

Modified Components (1)

Rating	Component	% Diff
	com1DFA	—

Modified Files with Diff Coverage (2)

File	% Diff	Uncovered Line #s
avaframe/com8MoTPSA/com8MoTPSA.py	0.0%	21-182
avaframe/in3Utils/cfgUtils.py	71.4%	995, 1016
Total	10.0%

🤖 Increase coverage with AI coding...

In the `RF_com8MoTPSA` branch, add test coverage for this new code:

- `avaframe/com8MoTPSA/com8MoTPSA.py` -- Line 21-182
- `avaframe/in3Utils/cfgUtils.py` -- Lines 995 and 1016

🚦 See full report on Qlty Cloud »

🛟 Help

Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.
Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.
File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)
- Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.

RolandFischbacher · 2026-02-24T15:27:55Z

avaframe/runScripts/runPlotAreaRefDiffs.py

+    if modName in ["com1DFA", "com5SnowSlide", "com6RockAvalanche", "com8MoTPSA", "com9MoTVoellmy"]:
+        # load dataFrame for all configurations of simulations in avalancheDir
+        simDF = cfgUtils.createConfigurationInfo(avalancheDir)
+        # create data frame that lists all available simulations and path to their result type result files
+        inputsDF, resTypeList = fU.makeSimFromResDF(avalancheDir, "com1DFA")


previously "com8MoTPSA" was not in if modName in [...], com1DFA is hard coded, thus not work for com8MoTPSA
removing com8MoTPSA works

RolandFischbacher requested review from awirb and fso42 February 23, 2026 17:47

RolandFischbacher self-assigned this Feb 23, 2026

RolandFischbacher added the enhancement New feature or request label Feb 23, 2026

qltysh bot reviewed Feb 23, 2026

View reviewed changes

fso42 added this to the Version 2.0 milestone Feb 23, 2026

fso42 changed the title ~~[ana6Opitmisation], [com8MoTPSA]: Add ana6Optimisation Module, apply changes in com8MoTPSA~~ [ana6, com8]: Add ana6Optimisation Module, apply changes in com8MoTPSA Feb 24, 2026

RolandFischbacher force-pushed the RF_com8MoTPSA branch from f66f702 to 38e42ca Compare February 24, 2026 08:50

qltysh bot reviewed Feb 24, 2026

View reviewed changes

fso42 assigned fso42 and unassigned RolandFischbacher Feb 24, 2026

fso42 force-pushed the RF_com8MoTPSA branch from 38e42ca to 15f5438 Compare February 24, 2026 14:35

qltysh bot reviewed Feb 24, 2026

View reviewed changes

fso42 assigned RolandFischbacher and unassigned fso42 Feb 24, 2026

RolandFischbacher commented Feb 24, 2026

View reviewed changes

		@@ -0,0 +1,140 @@
		# ana6 – Sensitivity Analysis & Optimisation

Conversation

RolandFischbacher commented Feb 23, 2026

The module ana6Optimisation includes:

Changed workflow of runing com8MoTPSA:

Uh oh!

qltysh bot commented Feb 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

❌ 10 blocking issues (18 total)

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

qltysh bot Feb 23, 2026

Choose a reason for hiding this comment

Uh oh!

qltysh bot Feb 23, 2026

Choose a reason for hiding this comment

Uh oh!

qltysh bot Feb 23, 2026

Choose a reason for hiding this comment

Uh oh!

qltysh bot Feb 23, 2026

Choose a reason for hiding this comment

Uh oh!

qltysh bot Feb 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

qltysh bot Feb 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

qltysh bot Feb 24, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

qltysh bot Feb 24, 2026

Choose a reason for hiding this comment

Uh oh!

qltysh bot Feb 24, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

qltysh bot Feb 24, 2026

Choose a reason for hiding this comment

Uh oh!

qltysh bot Feb 24, 2026

Choose a reason for hiding this comment

Uh oh!

qltysh bot Feb 24, 2026

Choose a reason for hiding this comment

Uh oh!

qltysh bot Feb 24, 2026

Choose a reason for hiding this comment

Uh oh!

qltysh bot commented Feb 24, 2026

Uh oh!

RolandFischbacher Feb 24, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

qltysh bot commented Feb 23, 2026 •

edited

Loading

qltysh bot Feb 23, 2026 •

edited

Loading

qltysh bot Feb 23, 2026 •

edited

Loading