Skip to content

Fix #1858 - crash when adding a modifier to a jewel #1866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dcollinsn wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Fix #1858 - crash when adding a modifier to a jewel #1866

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions Classes/ItemsTab.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1613,7 +1613,7 @@ function ItemsTabClass:AddCustomModifierToDisplayItem()
end)
end
end
if (self.build.targetVersion ~= "2_6" and self.displayItem.base.subType ~= "Abyss") or (self.displayItem.type ~= "Jewel" and self.displayItem.type ~= "Flask") then
if (self.build.targetVersion ~= "2_6" and self.displayItem.type ~= "Jewel") or (self.displayItem.type ~= "Jewel" and self.displayItem.type ~= "Flask") then
t_insert(sourceList, { label = "Crafting Bench", sourceId = "MASTER" })
end
if self.displayItem.type ~= "Jewel" and self.displayItem.type ~= "Flask" then
Expand All @@ -1635,8 +1635,10 @@ function ItemsTabClass:AddCustomModifierToDisplayItem()
end
else
local listMod = modList[controls.modSelect.selIndex]
for _, line in ipairs(listMod.mod) do
t_insert(item.modLines, { line = line, [listMod.type] = true })
if listMod then
for _, line in ipairs(listMod.mod) do
t_insert(item.modLines, { line = line, [listMod.type] = true })
end
end
end
item:BuildAndParseRaw()
Expand Down