Skip to content

Conversation

@koji
Copy link
Contributor

@koji koji commented Dec 6, 2025

Overview

before

button_focus.mov

after

primarybutton.mov
alt_primary-button.mov

Test Plan and Hands on Testing

  • make -C components dev
    check primary button and alt primary button work as well as other buttons

Changelog

  • modify PrimaryButton styling
  • modify AltPrimaryButton styling

Review requests

Risk assessment

low

@koji koji requested a review from ncdiehl11 December 6, 2025 02:36
ncdiehl11 and others added 6 commits December 5, 2025 21:37
…stom tipracks (#20278)

Always permit multi-well handling for custom tipracks, since we are
guaranteed to not find a matching set of liquid class tip specs.

Closes RQA-4930
…nceVolumes (#20280)

This PR ensures the actual selected values for `disposalVolume` and
`conditioningVolume` from the form are respected in calling
getTransferPlanAndReferenceVolumes, used to determine how many tip
pickups the pipette will need during its transfer.

Closes RQA-4930
In addition to checking external collisions in `pickUpTip` command
creator, we need to check that the tip pickup is valid (i.e., partially
configured pipettes won't pickup too many tips). This is blocked in the
tip selection UI, but the error can arise if saved steps are reordered,
deeming unsuccessful their tip selections at the time of step creation.
…#20288)

Add logic for OT-2 collision detection that is now more pressing for
8-channel partial tip pickup. Previously, we had hard-coded in the logic
for the Flex only (oops!).
@koji koji force-pushed the fix_primarybutton-focus-issue branch from c975d81 to 1c0deae Compare December 6, 2025 02:38
@koji koji closed this Dec 6, 2025
@codecov
Copy link

codecov bot commented Dec 6, 2025

Codecov Report

❌ Patch coverage is 65.53191% with 81 lines in your changes missing coverage. Please review.
✅ Project coverage is 25.85%. Comparing base (a102faf) to head (1c0deae).

Files with missing lines Patch % Lines
shared-data/js/helpers/getOt2SurroundingSlots.ts 9.37% 29 Missing ⚠️
...rm/PipetteFields/TipSelectionWizard/SelectTips.tsx 0.00% 17 Missing ⚠️
...andleFormChange/dependentFieldsUpdateMoveLiquid.ts 86.66% 6 Missing ⚠️
...Level/handleFormChange/dependentFieldsUpdateMix.ts 86.48% 5 Missing ⚠️
step-generation/src/errorCreators.ts 16.66% 5 Missing ⚠️
step-generation/src/utils/safePipetteMovements.ts 79.16% 5 Missing ⚠️
...lSteps/StepForm/PipetteFields/TipTrackingField.tsx 0.00% 4 Missing ⚠️
step-generation/src/utils/misc.ts 76.47% 4 Missing ⚠️
...isms/SelectLabwareModal/SelectLabwareOnAdapter.tsx 0.00% 2 Missing ⚠️
...generation/src/commandCreators/atomic/pickUpTip.ts 93.93% 2 Missing ⚠️
... and 2 more
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             edge   #20310      +/-   ##
==========================================
+ Coverage   25.83%   25.85%   +0.02%     
==========================================
  Files        3627     3628       +1     
  Lines      302041   302187     +146     
  Branches    42320    42332      +12     
==========================================
+ Hits        78020    78125     +105     
- Misses     223992   224033      +41     
  Partials       29       29              
Flag Coverage Δ
protocol-designer 19.38% <54.89%> (+0.03%) ⬆️
step-generation 5.60% <28.93%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...eplist/formLevel/handleFormChange/test/mix.test.ts 95.83% <100.00%> (+0.05%) ⬆️
...formLevel/handleFormChange/test/moveLiquid.test.ts 92.07% <100.00%> (+0.08%) ⬆️
shared-data/js/helpers/index.ts 62.62% <ø> (ø)
step-generation/src/constants.ts 98.43% <100.00%> (ø)
step-generation/src/types.ts 100.00% <ø> (ø)
components/src/atoms/buttons/AltPrimaryButton.tsx 87.50% <0.00%> (+8.55%) ⬆️
...ganisms/SelectLabwareModal/SelectCustomLabware.tsx 25.30% <0.00%> (-0.31%) ⬇️
...isms/SelectLabwareModal/SelectLabwareOnAdapter.tsx 51.96% <0.00%> (-0.26%) ⬇️
...generation/src/commandCreators/atomic/pickUpTip.ts 73.56% <93.93%> (+3.99%) ⬆️
...lSteps/StepForm/PipetteFields/TipTrackingField.tsx 1.16% <0.00%> (+0.11%) ⬆️
... and 7 more
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants