Skip to content

Conversation

@koji
Copy link
Contributor

@koji koji commented Dec 6, 2025

Overview

before

button_focus.mov

after

primarybutton.mov
alt_primary-button.mov

close AUTH-2559

Test Plan and Hands on Testing

  • make -C components dev
    check primary button and alt primary button work as well as other buttons

Changelog

  • modify PrimaryButton styling
  • modify AltPrimaryButton styling

Review requests

Risk assessment

low

fix primarybutton and alt primarybutton styling issue

close AUTH-2559
@koji koji requested a review from ncdiehl11 December 6, 2025 02:45
@koji koji marked this pull request as ready for review December 6, 2025 02:46
@koji koji requested a review from a team as a code owner December 6, 2025 02:46
@codecov
Copy link

codecov bot commented Dec 6, 2025

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 25.83%. Comparing base (a102faf) to head (a766645).

Files with missing lines Patch % Lines
components/src/atoms/buttons/AltPrimaryButton.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             edge   #20311      +/-   ##
==========================================
- Coverage   25.83%   25.83%   -0.01%     
==========================================
  Files        3627     3627              
  Lines      302041   302037       -4     
  Branches    42320    42320              
==========================================
- Hits        78020    78018       -2     
+ Misses     223992   223990       -2     
  Partials       29       29              
Flag Coverage Δ
protocol-designer 19.35% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
components/src/atoms/buttons/PrimaryButton.tsx 100.00% <ø> (ø)
components/src/atoms/buttons/AltPrimaryButton.tsx 87.50% <0.00%> (+8.55%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants