Add .test for Normal distribution#1
Merged
ilia-kats merged 5 commits intoPMBio:masterfrom Dec 20, 2024
Merged
Conversation
ilia-kats
reviewed
Dec 19, 2024
Collaborator
ilia-kats
left a comment
There was a problem hiding this comment.
Awesome, thanks for this. Looks good in general (I've only had a cursory look at the _do_test implementation, I trust that it's correct), but a few things aren't clear to me (see the specific comments).
ilia-kats
reviewed
Dec 20, 2024
Collaborator
ilia-kats
left a comment
There was a problem hiding this comment.
Looks good now. Could you just run the black formatter on the code?
ilia-kats
reviewed
Dec 20, 2024
Collaborator
|
Great, thank you. |
Author
|
Awesome! Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Observation modeled to have error with Normal distribution with mean field error and identity link function. i.e.,