Change thrown trident item to use copy of ItemStack of count 1 #13394
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lynxplay
reviewed
Dec 15, 2025
| + ThrownTrident thrownTrident = tridentDelayed.projectile(); // Paper - PlayerLaunchProjectileEvent | ||
| + if (event.shouldConsume()) { | ||
| + stack.hurtWithoutBreaking(1, player); // Paper - PlayerLaunchProjectileEvent | ||
| + itemStack.hurtWithoutBreaking(1, player); // Paper - PlayerLaunchProjectileEvent // Paper use itemStack; pickup item damage |
Contributor
There was a problem hiding this comment.
We are long hardforked from spigot, no need to add paper comments again, this code is already in a diff block.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13390
New change uses the defined
itemStackvariable to set the trident pick up item. TheitemStackvariable is a fixed value of 1.The
hurtWithoutBreakingcall is also switched over, this is to allow regular tridents to still take durability damage.