Don't print missing profile stacktrace #13420
Open
+17
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Strokkur424
approved these changes
Dec 21, 2025
mja00
changed the title
Toffikk
approved these changes
Dec 21, 2025
masmc05
approved these changes
Dec 21, 2025
Contributor
|
[Not saying it must be done] I wonder if it's worth putting this behind the server.properties debug toggle, to figure out why a server is failing to get info. |
Contributor
|
I'd agree with mbax. Might also make sense to maybe include some more in the debug like status code 💀 |
Contributor
Author
|
Yeah I can grab the status code pretty easily. Lemme look at gating the stacktrace behind that toggle. |
Contributor
Author
|
Done. Now it'll log the stacktrace if we're in debug mode and always log the HTTP status code and reason from the API. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason Mojang thought it'd be a good idea to log the entire error.