Add SGRID metadata support for node_coordinates attribute #2456
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are variables defined in the dataset, not actually dimensions.
VeckoTheGecko
commented
Jan 8, 2026
Comment on lines
+248
to
+251
| create_example_grid2dmetadata(with_node_coordinates=i, with_vertical_dimensions=j) | ||
| for i, j in itertools.product([False, True], [False, True]) | ||
| ] | ||
| + [create_example_grid3dmetadata(with_node_coordinates=i) for i in [False, True]], |
Contributor
Author
There was a problem hiding this comment.
Just a quick refactor so that we test all combinations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on #2447 , I realised that we weren't yet supporting the
node_coordinatesattribute in the SGRID conventions. This attribute specifies which variables in the dataset are used for the coordinates of the f-points.This is different to
node_dimensionswhich specifies the dimensions in which the nodes are defined (similar to theface_dimensionsattribute).just thought to split out for ease of reviewing since this is nicely orthogonal
Might be easier to review commit by commit as there's one commit for refactoring