Standardize pg_regress usage#12
Merged
steve-chavez merged 1 commit intoPostgREST:masterfrom Feb 28, 2026
Merged
Conversation
Standard PGXS `make installcheck` usage depends on a existing postgres server. Tests will run in a contrib_regression database created by pg_regress. The pg_regress option --use-existing makes pg_regress require an existing contrib_regression database, but the Makefile does not create it. Removing that option makes using the testsuite easier. Similarly, the init.sql file was not loaded by the Makefile, but it is required to run the tests. Move it into tests/sql/ and name it 00_init.sql so it gets run first. With these changes, the testsuite runs without any further tweaking during the Debian package builds for apt.postgresql.org. Signed-off-by: Christoph Berg <myon@debian.org>
Member
@df7cb Cool, that really simplifies things. Many thanks! |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Standard PGXS
make installcheckusage depends on a existing postgres server. Tests will run in a contrib_regression database created by pg_regress.The pg_regress option --use-existing makes pg_regress require an existing contrib_regression database, but the Makefile does not create it. Removing that option makes using the testsuite easier.
Similarly, the init.sql file was not loaded by the Makefile, but it is required to run the tests. Move it into tests/sql/ and name it 00_init.sql so it gets run first.
With these changes, the testsuite runs without any further tweaking during the Debian package builds for apt.postgresql.org.