Update to Swift 5#5
Open
ChaosCoder wants to merge 1 commit intoPromiseKit:masterfrom
ChaosCoder:feature/swift5
Open
Update to Swift 5#5ChaosCoder wants to merge 1 commit intoPromiseKit:masterfrom ChaosCoder:feature/swift5
ChaosCoder wants to merge 1 commit intoPromiseKit:masterfrom
ChaosCoder:feature/swift5
Conversation
Member
|
This is not possible or we break for all pre Swift 5 Carthage users. |
Contributor
Author
|
I see your point. Maybe add a swift5 branch then, as a lot of repositories do, to eliminate "Migrate to Swift 5"-messages regarding this library? |
Member
|
Our strategy with other extensions was to migrate to 4.2, can reopen if you submit that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There's not much to do here, but it's good to keep up with the time. ;)