Skip to content

Conversation

@ToothyDev
Copy link
Contributor

@ToothyDev ToothyDev commented Jan 26, 2026

Summary

Previously, an update to a user's primary guild would not fire the on_user_update event. This is now the case. The underlying dict for users was also updated with the missing primary_guild key

Information

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting,
    examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.
  • I have updated the changelog to include these changes.

@pycord-app
Copy link

pycord-app bot commented Jan 26, 2026

Thanks for opening this pull request!
Please make sure you have read the Contributing Guidelines and Code of Conduct.

This pull request can be checked-out with:

git fetch origin pull/3077/head:pr-3077
git checkout pr-3077

This pull request can be installed with:

pip install git+https://github.com/Pycord-Development/pycord@refs/pull/3077/head

@ToothyDev ToothyDev changed the title fix: 🐛 Primary guild not firing on_user_update fix: 🐛 Primary guild update not firing on_user_update Jan 26, 2026
Soheab
Soheab previously approved these changes Jan 26, 2026
@Paillat-dev Paillat-dev added priority: low Low Priority hold: testing This pull request requires further testing labels Jan 26, 2026
@Paillat-dev Paillat-dev added this to the v2.8 milestone Jan 26, 2026
Lulalaby
Lulalaby previously approved these changes Jan 26, 2026
Copy link
Member

@Lulalaby Lulalaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That should work for now

Copy link
Member

@Paillat-dev Paillat-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

after.primary_guild is not a PrimaryGuild object in my testing but rather just a dictionary

@Paillat-dev
Copy link
Member

Getting the event twice:

User Update Event:
  User: 'paillat' (ID: 707196665668436019)
  Primary Guild Before: <PrimaryGuild identity_guild_id=1317206872763404478 identity_enabled=True tag=CAP>
  Primary Guild After:  None
User Update Event:
  User: 'paillat' (ID: 707196665668436019)
  Primary Guild Before: <PrimaryGuild identity_guild_id=1317206872763404478 identity_enabled=True tag=CAP>
  Primary Guild After:  None

Copy link
Member

@Paillat-dev Paillat-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, works. Mostly nitpick.

@Paillat-dev Paillat-dev removed the hold: testing This pull request requires further testing label Jan 28, 2026
Paillat-dev
Paillat-dev previously approved these changes Jan 28, 2026
Copy link
Member

@Paillat-dev Paillat-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm; tested; nice pr :)

Copy link
Member

@Paillat-dev Paillat-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm; tested; nice pr, thank you !

Copy link
Member

@Lulalaby Lulalaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

W

@Paillat-dev Paillat-dev merged commit b17efde into Pycord-Development:master Jan 29, 2026
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

priority: low Low Priority

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants