Tashee core 8786

[tashee]

The basics

• I validated my changes

The details

Resolves

Fixes issue #8786

Proposed Changes

Add getter to ContextMenu

Reason for Changes

Currently, the ContextMenu module provides no way to get at the underlying Menu instance, which may be convenient.

Test Coverage

Tests to be added separately.

Documentation

N/A

Additional Information

N/A

[BenHenning]

Thanks @tashee! Apologies for the delayed response here. Some requests:

• The lint & label workflow is failing. I think this is due to your PR title being incorrectly formatted. Can you please fix that to match other PRs? E.g. 'fix: ' is a great format to use.
• Could you perhaps go ahead and add tests for the new getter in this PR? It's generally better to add tests with the code change so that we can help verify that it works and not forget to add them later. :)
• Could you please sync with the latest develop changes as well? That should fix the welcome contributor workflow.

The keyboard navigation webdriver tests should be unrelated flakes from what I can tell.

[BenHenning]

One thing that would be really helpful to include is context on the menu's lifecycle. Specifically:

• When is it defined? (Relative to other functions called here)
• When is null returned? What does that mean/what can the caller infer from receiving a null value?
• Is it valid to save the returned value or could that cause problems (e.g. if the menu is later closed)?

These would be great to clarify in the documentation here for a more solid defined API contract for callers.