Animation on Cancel whilst scanning#345
Open
JSmyth886 wants to merge 1 commit intoRedth:masterfrom
JSmyth886:master
Open
Animation on Cancel whilst scanning#345JSmyth886 wants to merge 1 commit intoRedth:masterfrom JSmyth886:master
JSmyth886 wants to merge 1 commit intoRedth:masterfrom
JSmyth886:master
Conversation
Made the Cancel animation softer and now depending on the iOS version. Moved the boolean logic to decide iOS version globally and used this for the decision. Also removed some duplications
Owner
|
Would you be able to rebase on master? That should fix the CI builds... |
| // Calling with animated:true here will result in a blank screen when the scanner is closed on iOS 7. | ||
| ((UIViewController)viewController).DismissViewController(false, null); | ||
| // Calling with animated:true here will result in a blank screen when the scanner is closed on iOS 7. | ||
| ((UIViewController)viewController).DismissViewController(is7orgreater, null); |
Contributor
There was a problem hiding this comment.
Comment conflicts with the code. On ios7 value is true - is it ok?
Author
There was a problem hiding this comment.
Sorry, should have changed the comment. On iOS7 value of is7orgreater should be false and I've just looked at my check in the Initialise method and it's wrong, should be:
is7orgreater = sv.Major > 7;
Author
|
I shall rebase and make any changes needed tonight. |
Owner
|
Agreed please use (8,0) instead :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Made the Cancel animation softer and now depending on the iOS version.
Moved the boolean logic to decide iOS version globally and used this
for the decision. Also removed some duplications