-
Notifications
You must be signed in to change notification settings - Fork 4
feat: replace deprecated Stably USDS with Sky USDS #14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Note Other AI code review bot(s) detectedCodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review. WalkthroughThe pull request updates the USDS token entry in the token list, consolidating multiple USDS variants into a single entry. Two USDS entries are removed, and the remaining USDS-mainnet entry is updated with new decimals (18) and a revised contract address (0xdC035D45d973E3EC169d2276DDab16f1e407384F). Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Possibly related PRs
Suggested reviewers
Pre-merge checks and finishing touches✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR removes a duplicate USDS token entry from the token list. The change consolidates two USDS token entries on mainnet by removing the older "StableUSD" token (with ID "USDS-mainnet") that had 6 decimals and address 0xA4Bdb11dc0a2bEC88d24A3aa1E6Bb17201112eBe, keeping only the current USDS token with 18 decimals and address 0xdC035D45d973E3EC169d2276DDab16f1e407384F.
- Removed the deprecated StableUSD token entry with ID "USDS-mainnet"
- Consolidated the USDS token entries to keep only the active token
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Problem
The token list contains the old deprecated Stably USDS token (address
0xA4Bdb11dc0a2bEC88d24A3aa1E6Bb17201112eBe) which has been superseded by Sky USDS (address0xdC035D45d973E3EC169d2276DDab16f1e407384F). Additionally, the token list uses IDUSDS-sky-mainnetwhile Request Finance's API usesUSDS-mainnet, creating naming inconsistency.Background on Stably USDS deprecation:
According to Etherscan, "StableUSD has been renamed to Stably USD Classic (USDSC) and is no longer supported by the issuer." The token has been deprecated and Stably is no longer maintaining this stablecoin. For more information, see https://stably.io/usdsc.
Proposed Solution
USDS-sky-mainnettoUSDS-mainnet(reusing the freed ID)This aligns the token list with Request Finance's currency endpoint naming convention.
Considerations
Context:
This change was originally proposed by @pclaesen in #12. At that time, I preserved the old Stably USDS token for backward compatibility concerns. After database verification confirmed zero production usage of the old token (address
0xA4Bdb11dc0a2bEC88d24A3aa1E6Bb17201112eBe), it's now safe to complete the migration that @pclaesen originally intended.Why reusing the ID is safe:
USDS-mainnetfor Sky USDS (not Stably), which implies they also never used the deprecated Stably USDS token0xA4Bdb...vs0xdC035D...), preventing any collisionImpact:
USDS-mainnetID matching Request Finance APICo-authored-by: @pclaesen