Skip to content

fix: resolve emoji rendering and translation interpolation issues#9

Open
SinghaAnirban005 wants to merge 1 commit intoRocketChat:mainfrom
SinghaAnirban005:markdown
Open

fix: resolve emoji rendering and translation interpolation issues#9
SinghaAnirban005 wants to merge 1 commit intoRocketChat:mainfrom
SinghaAnirban005:markdown

Conversation

@SinghaAnirban005
Copy link

@SinghaAnirban005 SinghaAnirban005 commented Jan 23, 2025

Title

Fix emoji rendering and translation interpolation issues

Fixes #8

Description:

This PR addresses two issues:

  • Placeholder text in the /agile-settings modal did not render the 😄 emoji visually.
  • Translations with variable interpolation, such as poll_with_uuid_not_found: 'Poll with ID ${uuid} not found', were not replacing correctly.

Videos / Screenshots

general.-.1.unread.message.-.Singha.-.Brave.2025-01-23.14-54-49.mp4

@SinghaAnirban005 SinghaAnirban005 marked this pull request as ready for review January 23, 2025 09:31
@SinghaAnirban005
Copy link
Author

Hey @dieselftw , could you kindly review this PR when you have a moment ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Placeholder text and variable interpolation issues in modal and translations

1 participant