gccrs: fix parser error on parenthesised types #4214
Merged
+16
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
P-E-P
requested changes
Nov 26, 2025
Villosse
force-pushed
the
4148
branch
8 times, most recently
from
7c5bd8d to
68fc3aa
Compare
Do not cast parenthesised types to TraitBound types. Fixes Rust-GCC#4148 gcc/rust/ChangeLog: * ast/rust-path.cc (TypePath::to_trait_bound): Check if in parenthesis. * hir/tree/rust-hir-type.cc (ParenthesisedType::to_trait_bound): Likewise. * hir/tree/rust-hir.cc (TypePath::to_trait_bound): Likewise. gcc/testsuite/ChangeLog: * rust/compile/issue-4148.rs: Test should produce errors. Signed-off-by: lenny.chiadmi-delage <[email protected]>
P-E-P
approved these changes
Dec 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not cast parenthesised types to TraitBound types
Fixes #4148
gcc/rust/ChangeLog:
gcc/testsuite/ChangeLog:
Thank you for making Rust GCC better!
If your PR fixes an issue, you can add "Fixes #issue_number" into this
PR description and the git commit message. This way the issue will be
automatically closed when your PR is merged. If your change addresses
an issue but does not fully fix it please mark it as "Addresses #issue_number"
in the git commit message.
Here is a checklist to help you with your PR.
make check-rustpasses locallyclang-formatgcc/testsuite/rust/Note that you can skip the above if you are just opening a WIP PR in
order to get feedback.
*Please write a comment explaining your change. This is the message
that will be part of the merge commit.