Make some general improvements #4332
Merged
+7
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gcc/rust/ChangeLog: * ast/rust-ast-visitor.cc (DefaultASTVisitor::visit): Visit the generic parameters of TraitItemType. * expand/rust-expand-visitor.h (is_derive): Remove defunct function declaration. * hir/rust-ast-lower-item.cc (ASTLoweringItem::visit): Remove unnecessary copy. * resolve/rust-name-resolver.cc (Resolver::Resolver): Skip generating builtins for the old resolver. * util/rust-hir-map.cc (Mappings::get_next_node_id): Detect node id exhaustion. * util/rust-mapping-common.h (MAX_NODEID): Add macro definition. Signed-off-by: Owen Avery <[email protected]>
P-E-P
approved these changes
Dec 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found these while working on #4323, but they apply more generally so I've broken them out into a separate PR.