Add Settings for Destination URL Validation #371
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 Need this feature for me as well. It is supported in php library: https://github.com/onelogin/php-saml |
Contributor
|
Disclaimer: I'm not a maintainer and I don't know whether this change is desirable or not. Maybe a hint on why one may desire to disable this validation (which is mandated by SAML specification) would help though to understand the usage scenario. Just a little note: perhaps the setter should better be called |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support to control & optionally disable
DestinationURL validation using a settings flag. The validation is enabled by default to ensure secure by default configuration. However provide an option to the library user to explicitly disable destination URL validation if required.