[SYNPY-1744] Redo how curator extension checks imports

[andrewelamb]

SYNPY-1744

Problem:

When the Curator Extension functions are called, but the specific packages haven't been installed, the error messaging was more or less useful depending on the package. For example, if only the inflection package is missing the camelize function wouldn't be available, and things would break with a very unhelpful exception to users.

Solution:

A function was added that checks that all Curator Extension packages are importable. This is called by generate_json_schema and generate_jsonld. If this function can't import all packages, a helpful message is part of an ImportException that is raised, telling the user how to install the Curator packages.

In addition, the jsonschema package is only used for testing, so it was moved from the curator section to the tests section in setup.cfg.

[BryanFauble]

Thanks for updating this to make this clearer what the users should be doing! I tested this out and can verify I got the ImportError:

ImportError: One or more packages needed for the Curator extension are not installed.Please install using 'pip install --upgrade 'synapseclient[curator]'

[thomasyu888]

Why did this move? Does curator not need this package anymore?

[andrewelamb]

So it was never in the Curator extension code. It is part of the tests for Curator extension.

[thomasyu888]

To discuss: Should this be in core.utils?

[andrewelamb]

It could be. It is only used here in this file though, and I doubt it will be used elswhere.

[thomasyu888]

🔥 thanks for the quick work and review!