SCANGRADLE-317 Compute libraries in SonarResolverTask configuration instead of SonarPropertyComputer #399
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romainbrenguier
force-pushed
the
romain/317-libraries
branch
2 times, most recently
from
8a860dc to
0cc9173
Compare
Move getRuntimeJars(), getRuntimeJar(), and getFxRuntimeJar() methods from SonarPropertyComputer to SonarUtils to make them reusable across the codebase. This is a preparation step for uniformizing library computation in SonarResolverTask for all project types. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
…Android projects Remove getRuntimeJars(), getRuntimeJar(), and getFxRuntimeJar() methods from SonarPropertyComputer as library computation is now handled in SonarResolverTask for both Android and non-Android projects. Also refactor SonarUtils helper methods: - Rename setMainClasspathProps to setMainBinariesProps and remove library parameters - Remove setTestClasspathProps and inline test binaries setting Add library computation for non-Android projects in SonarResolverTask by introducing setJavaLibrariesProperties() method that sets both main and test libraries to Java/JavaFX runtime jars. This uniformizes library computation across all project types: - Android projects: libraries resolved from Android dependencies - Non-Android projects: libraries resolved from Java/JavaFX runtime jars 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Remove the outdated comment about libraries only being populated for Android projects, as libraries are now computed in SonarResolverTask for all project types. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
To avoid code duplication
romainbrenguier
force-pushed
the
romain/317-libraries
branch
from
05f5539 to
7abb51f
Compare
dorian-burihabwa-sonarsource
approved these changes
Nov 18, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Uniformize library computation across all project types by moving it to
SonarResolverTaskconfiguration phase.Previously, only Android projects computed libraries in
SonarResolverTask, while non-Android projects computed them inSonarPropertyComputerbecause of a parallel execution issues with Gradle 9.1.0 (SCANGRADLE-292).This issue could potentially also happen for non-Android project, which we aim to address with this PR.
Now all projects (Android and non-Android) compute libraries during task configuration in
SonarResolverTask, making it safe for parallel execution.Changes
getRuntimeJars()methods toSonarUtilsfor reusesetJavaLibrariesProperties()to configure libraries for non-Android projectsSonarPropertyComputerThis pull request is based on #391, and needs to be rebased before review.
Please be aware that we are not actively looking for feature contributions. The truth is that it's extremely difficult for someone outside SonarSource to comply with our roadmap and expectations. Therefore, we typically only accept minor cosmetic changes and typo fixes. If you would like to see a new feature, please create a new thread in the forum "Suggest new features".
With that in mind, if you would like to submit a code contribution, make sure that you adhere to the following guidelines and all tests are passing:
We will try to give you feedback on your contribution as quickly as possible.
Thank You!
The SonarSource Team