Skip to content

Converted JavaScript to TypeScript & Updated React#15

Merged
logbasem merged 14 commits intomainfrom
typescript-conversion
Feb 17, 2026
Merged

Converted JavaScript to TypeScript & Updated React#15
logbasem merged 14 commits intomainfrom
typescript-conversion

Conversation

@logbasem
Copy link

Performed a basic conversion from JavaScript to Typescript in React project

  • Updated React version
  • Changed file types
  • Updated dependencies
  • Fixed TypeScript errors (trivially, there will probably be more work to be done to make the code nice and pretty)
  • Set up tsconfig.json for TypeScript rules (including no implicit any)
  • Tested to make sure the frontend runs without errors
  • Added a TODO for displaying an error when cameras list is null

Camera test

  • Also added a tests folder and put the fake cameras unit test in there in case we want to have an actual version of that later in the future

@logbasem logbasem requested a review from onkoe February 17, 2026 18:07
Copy link
Member

@onkoe onkoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

make sure you're using the biome formatter as opposed to something else; otherwise, there's a bit of a formatting war.

<div className="camera-select">
<label htmlFor="cameraSelect">Select Camera: </label>
<select
<div className="App" >
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there are a lotta formatting changes like this. are they intentional?

note: in the future, we should probably use something like biome in CI to make formatting uniform; prettier is less consistent, which might be what's going on here..?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does biome require pnpm? I'm getting an error about how it needs it. The formatting changes are probably a result of my automatic format-on-save settings, I can't use biome formatter for it rn though because it isn't working for me. If you want that to be the standard formatter for this repository, we should probably document that somewhere?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think so; it features installation instructions for npm here: https://biomejs.dev/guides/getting-started/

@onkoe
Copy link
Member

onkoe commented Feb 17, 2026

oh also... @logbasem do you know why the CI's failing? there seems to be some kinda problem with testing-library

nvm seems like there's something weird with react-scripts? idk what that is, but it seems to be only used for the template stuff; do we even need it? ;D

Copy link
Member

@onkoe onkoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! no notes

@logbasem logbasem merged commit 8a7bc85 into main Feb 17, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments