Converted JavaScript to TypeScript & Updated React#15
Conversation
onkoe
left a comment
There was a problem hiding this comment.
looks good!
make sure you're using the biome formatter as opposed to something else; otherwise, there's a bit of a formatting war.
| <div className="camera-select"> | ||
| <label htmlFor="cameraSelect">Select Camera: </label> | ||
| <select | ||
| <div className="App" > |
There was a problem hiding this comment.
there are a lotta formatting changes like this. are they intentional?
note: in the future, we should probably use something like biome in CI to make formatting uniform; prettier is less consistent, which might be what's going on here..?
There was a problem hiding this comment.
Does biome require pnpm? I'm getting an error about how it needs it. The formatting changes are probably a result of my automatic format-on-save settings, I can't use biome formatter for it rn though because it isn't working for me. If you want that to be the standard formatter for this repository, we should probably document that somewhere?
There was a problem hiding this comment.
I don't think so; it features installation instructions for npm here: https://biomejs.dev/guides/getting-started/
|
oh also... @logbasem do you know why the CI's failing? nvm seems like there's something weird with |
Performed a basic conversion from JavaScript to Typescript in React project
Camera test