[Discussion] Add method to force loading Templates into memory#2853
Draft
h-mayorquin wants to merge 1 commit intoSpikeInterface:mainfrom
Draft
[Discussion] Add method to force loading Templates into memory#2853h-mayorquin wants to merge 1 commit intoSpikeInterface:mainfrom
h-mayorquin wants to merge 1 commit intoSpikeInterface:mainfrom
Conversation
h-mayorquin
changed the title
h-mayorquin
changed the title
Member
|
Is it still a draft ? |
Collaborator
Author
|
I wanted to know what you think guys, I am not sure this si better than what we do now after the hybrid tools big PR which is loading everything from the beginning. That's the reason I put it as a draft. |
Collaborator
Author
|
I don't think this should go in the next release. It is a minor detail that is discussion more than anything. I would remove the tag. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Discussion PR. @samuelgarcia @alejoe91
Following on #2828 and as alternative to the code in #2436.
With this, if you are in a scenario (I guess like plotting?) where you are going to be making repeated calls to the functions then you can call this function. We can even add an argument to the signature and call this at post_init.
The advantage of this vs loading by default is that the
__init__of the object becomes lighter at the cost of some complexity.What do you think?