Proof of concept for handling alarms and timers via Android intents #376
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More of a proof-of-concept than an actual PR since this drastically changes the way that alarms and timers are handled. I personally prefer this method but it does severely limit the amount of information Dicio can get after an alarm/timer is set. Right now, any queries about active timers/alarms are handled by just opening the clock app of the user's choosing.
There may be additional refactoring needed in the dicio-numbers library to handle military/24-hour time as I encountered some issues with setting alarms/timers with that format.
Resolves #84, #232