Use base-orphans to make the GHC.Generics instances unconditional
#13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
It would be good to first merge
|
Owner
|
My gut feeling is against this change, but I do have to admit it feels useful to have. Thanks for doing it in either case, I'll ruminate a bit on it. |
Contributor
Author
|
Yeah I understand that. We did it by accident in I wrote https://discourse.haskell.org/t/pre-hftp-decoupling-base-and-ghc/3727 for what I think ought to be the real solution, namely old GHCs just getting newer libraries with these instances. |
Contributor
Author
|
(nothing urgent here, just rebasing out of fastidiousness.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8